915139 - Test failure "The page has mixed content" in /testSecurity/testMixedContentPage.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Cosmin Malutan, [:cosmin-malutan]]

This happend on Linux Ubuntu 13.04 with Nightly en-US 
http://mozmill-daily.blargon7.com/#/functional/report/26d5854914a68aa13b333f2815977abe

Comment 1

[Cosmin Malutan, [:cosmin-malutan]]

It reproduces locally so it should be P1 .

Comment 2

[Andreea Matei [:AndreeaMatei]]

Here it should be identity.mixed_display_loaded instead of identity.mixed_display_loaded_active_blocked:

http://mxr.mozilla.org/l10n-central/source/it/browser/chrome/browser/browser.properties#147

I tested with that and it fixes the issue. I wonder where was this changed.

Comment 3

[Andreea Matei [:AndreeaMatei]]

Attachment: skip patch

Adding skip patch until I can further see where this was changed and fully test on several locales. I see that some locales have different properties, for example [ar] doesn't have identity.mixed_display_loaded_active_blocked or identity.mixed_display_loaded:
http://mxr.mozilla.org/l10n-central/source/ar/browser/chrome/browser/browser.properties#214

Comment 4

[Andrei Eftimie]

Comment on attachment 802988 [details] [diff] [review]
skip patch

Review of attachment 802988 [details] [diff] [review]:
-----------------------------------------------------------------

Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/ffe13db173e0 (default)

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Not sure why this has been set as critical. Moving back to normal.

(In reply to Andreea Matei [:AndreeaMatei] from comment #3)
> test on several locales. I see that some locales have different properties,
> for example [ar] doesn't have identity.mixed_display_loaded_active_blocked
> or identity.mixed_display_loaded:

Right. Not all locales are always up to date. If no property or DTD entity is available it will fall back to en-US during the repack. Flod might be able to explain that better or help us here.

Comment 6

[Francesco Lodolo [:flod] (OOO Oct 3–10)]

You can see the status of locales on their dashboard. For example "ar"
https://l10n.mozilla.org/shipping/dashboard?locale=ar

And then click on "C" for the product you're interested in. For example this is the current status of Firefox on trunk (fx_central) for ar
https://l10n.mozilla.org/dashboard/compare?run=340853

At build time strings missing from the locale are automatically added from en-US, so localized builds are always string complete and fully functional (missing string = yellow screen of death or not working functions).

Comment 7

[Andreea Matei [:AndreeaMatei]]

The only related changeset from this range (yesterday build vs today's) I can find is this one:
http://hg.mozilla.org/mozilla-central/rev/e9a2e269aa9e

related to bug 912817.

Changing the property to identity.mixed_display_loaded is fixing today's failures (most popular locales), but not sure about other locales at the moment, as mentioned [ar] which doesn't have that property.

Comment 8

[Andreea Matei [:AndreeaMatei]]

Thanks for the links Francesco, good to know!
So in [ar] we fail at the favicon check, if I skip that part and replace the correct property, we're green. Investigating further the favicon issue and check some more locales to fix as many as possible.

Comment 9

[Andreea Matei [:AndreeaMatei]]

Attachment: patch v1

Updated the property, checked on all platforms with several locales and it works fine.

Reports:
- http://mozmill-crowd.blargon7.com/#/remote/report/dc3d4d2f66af31b9e75e291fa048d893
- http://mozmill-crowd.blargon7.com/#/remote/report/dc3d4d2f66af31b9e75e291fa0486249
- http://mozmill-crowd.blargon7.com/#/remote/report/dc3d4d2f66af31b9e75e291fa048546a

I did noticed zh-tw on Ubuntu is failing at the favicon check, where it has the globe image, not the triangle. I'll file another bug to further investigate that (but I can reproduce manually). Might be related to bug 914410.

Comment 10

[Andreea Matei [:AndreeaMatei]]

I didn't had the last zh-TW apparently, but I do see the issue from bug 914410 if I click the favicon :)
Test works fine there as well:
http://mozmill-crowd.blargon7.com/#/remote/report/dc3d4d2f66af31b9e75e291fa04c2edc

Comment 11

[Andrei Eftimie]

Comment on attachment 804435 [details] [diff] [review]
patch v1

Review of attachment 804435 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/f4e461f75f13 (default)