91547 - Active Accessibility: Bounds for textfields in combobox gets reported wrong in accessibility

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[John Gaunt (redfive)]

Using the inspect object tool from the msaa sdk. Set the tool to show the focus 
with a highlight ring and mark off the select with mouse. navigate in the 
mfcembed app ( not sure if it shows up on mozilla but I suspect it does ) to a 
combobox. Use the navigation on the inspect tool to go into the children of the 
combox and see that the focus ring for the textfield ( and the button actually ) 
get shown in the wrong place. About half a screen up and slightly to the left.

Expected behavior is obviously to show around the textfield and button 
themselves. :-)

In going through the code and talking with a couple people it seems that we are 
not using the correct offset to locate the absolute screen position.

Comment 1

[John Gaunt (redfive)]

Attachment: v1.0 patch, change the frame we return as the "aRelativeFrame"

Comment 2

[Aaron Leventhal]

Please change the variable name from aRelativeFrame to aBoundingFrame

(I know this might be used in some other places, but in the last sr= we were
asked to use the variable name aBoundingFrame to make it easier to understand).

Also, I think we should use assertions at some point, rather than #ifdef DEBUG
and return. At least that way we find out about it during a debug build, instead
of a quiet failure.

r=aaronl

Comment 3

[John Gaunt (redfive)]

Attachment: v1.1 of diff, changed the aRel.. to aBounding...

Comment 4

[Chris Waterson]

rs=waterson

Comment 5

[John Gaunt (redfive)]

Attachment: v3.0 of the fix return using IEnumVARIANT

Comment 6

[John Gaunt (redfive)]

whoops, posted diff to wrong bug. John needs more sleep.

diff v1.1 was checked into the tree yesterday (Wed. 8/1/1).

Comment 7

[John Morrison]

May God have mercy on us all. The 212 bug spam-o-rama is Now!

Comment 8

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381