915574 - Use MOZ_FOLD_LIBS in SeaMonkey, too

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Frank Wein [:mcsmurf]]

Firefox and Thunderbird now use MOZ_FOLD_LIBS to fold NSPR, NSS and sqlite into mozjs or libxul library (perf win). SeaMonkey should use it, too. See Attachment 711540 [details] [diff] for the required changes. The required installer packaging changes have already landed a few weeks ago.

Comment 1

[Stefan Sitter [:ssitter]]

Not having MOZ_FOLD_LIBS defined in SeaMonkey might be the cause for Bug 922777.

Comment 2

[Philip Chee]

Attachment: v0.1 WIP Patch Add MOZ_FOLD_LIBS=1 to confvars.sh

Some copy and paste from Firefox.

Comment 3

[Philip Chee]

(In reply to Philip Chee from comment #2)
> Created attachment 8335275 [details] [diff] [review]
> v0.1 WIP Patch Add MOZ_FOLD_LIBS=1 to confvars.sh

Some problems:
xpcshell won't start can't find NSPR4.dll
SeaMonkey won't start can't find NSPR4.dll

Manually adding this allows xpcshell to run (needed for make package and make installer)
Manually adding this allows SeaMonkey to work. Lightning seems to be working.

Comment 4

[Frank Wein [:mcsmurf]]

Did you clobber? Everything seems to be working fine here with this patch.

Comment 5

[Philip Chee]

Comment on attachment 8335275 [details] [diff] [review]
v0.1 WIP Patch Add MOZ_FOLD_LIBS=1 to confvars.sh

(In reply to Frank Wein [:mcsmurf] from comment #4)
> Did you clobber? Everything seems to be working fine here with this patch.
A CLOBBER WORKED.

Comment 6

[Frank Wein [:mcsmurf]]

Comment on attachment 8335275 [details] [diff] [review]
v0.1 WIP Patch Add MOZ_FOLD_LIBS=1 to confvars.sh

Looks good, seems to work, installer changes are already in place. So the patch can land.

Comment 7

[Stefan Sitter [:ssitter]]

Thunderbird uses MOZ_FOLD_LIBS=1 at least up to comm-beta. Therefore Lightning 2.8/2.9/3.0 with SeaMonkey 2.23/2.24/2.25 might be affected and observing Bug 922777.

Comment 8

[Philip Chee]

Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/bcc114661851

Comment 9

[Philip Chee]

Comment on attachment 8335275 [details] [diff] [review]
v0.1 WIP Patch Add MOZ_FOLD_LIBS=1 to confvars.sh

[Approval Request Comment]
Regression caused by (bug #): m-c Bug 648407
User impact if declined:  Lightning 2.9/3.0 doesn't work in SeaMonkey 2.24/2.25 (Bug 922777)
Testing completed (on m-c, etc.): tested on comm-central.
Risk to taking this patch (and alternatives if risky): no known risks. This mirrors what Thunderbird has already done.
String changes made by this patch: None.

Comment 10

[Stefan Sitter [:ssitter]]

I can confirm that this change fixed the incompatibility with binary extensions that were build together with Thunderbird (Bug 922777).

Comment 11

[Philip Chee]

remote:   https://hg.mozilla.org/releases/comm-aurora/rev/2c51f85a67e9
remote:   https://hg.mozilla.org/releases/comm-beta/rev/24a9e761a614