922777 - Lightning 2.9/3.0 doesn't work in SeaMonkey 2.24/2.25 (but works in Thunderbird 27.0/28.0)

Status: RESOLVED FIXED

(Calendar :: Lightning: SeaMonkey Integration, defect)

Description

[Stefan Sitter [:ssitter]]

Lightning 2.9a1 (20131001030211)
Thunderbird 27.0a1 (20131001030211)
SeaMonkey 2.24a1 (20131001003001)

STR:
1) create new SeaMonkey profile
2) install Lightning
3) restart

Error: 
Lightning doesn't start up correctly, calendar tab is empty, ... but the very same Lightning package works in Thunderbird 27.0a1. Extract from console shows:

Failed to load native module at path '[...]\extensions\{e2fda1a4-762b-4020-b5ad-a41df1933103}\components\calbasecomps.dll': (80004003) error 127

[JavaScript Error: "TypeError: Components.classes[cid] is undefined" {file: "chrome://calendar/content/calUtils.js" line: 22}]

[JavaScript Error: "Components.classes['@mozilla.org/calendar/datetime;1'] is undefined" {file: "resource://calendar/modules/calUtils.jsm -> [...]/calendar-js/calDateTimeFormatter.js" line: 25}]

[JavaScript Error: "NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]" {file: "chrome://calendar/content/calUtils.js" line: 98}]

Comment 1

[u331436]

Confirming the issues with Aurora builds (20131017013001)
Seamonkey 2.23a2 (20131017013001)
Lightning 2.8aa2 (20131017013001) 

Error: TypeError: Components.classes[cid] is undefined
Source File: chrome://calendar/content/calUtils.js
Line: 22

Error: TypeError: (intermediate value).tabInfo[(intermediate value)] is undefined
Source File: chrome://messenger/content/msgMail3PaneWindow.js
Line: 146

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This can only be bug 927073 if it works on Win/Mac but fails on Linux. Looking at the comments this doesn't seem to be the case?

Comment 3

[Stefan Sitter [:ssitter]]

I see the error on Windows platform. Don't know if Mac OS X or Linux are affected too. Therefore I don't think bug 927073 matters here. Maybe there is some build setting or build toolchain difference that causes binary incompatibility?

Comment 4

[Stefan Sitter [:ssitter]]

Attachment: missing calbasecomps.dll dependencies

Screenshot shows the dependencies graph of calbasecomps.dll when used in Thunderbird vs. SeaMonkey.

Left part shows that in Thunderbird all dependencies are fulfilled.

Right part shows that in SeaMonkey there are missing dependencies to nss3.dll. 

Seems there is difference in how nss3.dll is build in Thunderbird and SeaMonkey causing the problem.

Comment 5

[Stefan Sitter [:ssitter]]

In addition I noticed that in SeaMonkey nss3.dll depends on files like nspr4.dll or plc4.dll or plds4.dll that are not available in Thunderbird. Looking at installer/package-manifest.in and installer/removed-files.in I see that the availability of this files depends on MOZ_FOLD_LIBS define.

For Thunderbird MOZ_FOLD_LIBS=1 was added to mail/confvars.sh on 2013-09-09 with http://hg.mozilla.org/comm-central/rev/adbc208dc608

For SeaMonkey MOZ_FOLD_LIBS doesn't seem to be set but there is Bug 915574 to do it.

Comment 6

[Frank Wein [:mcsmurf]]

Good catch. Yeah, could likely be that the missing MOZ_FOLD_LIBS define is the issue here when Lightning binaries are built against the Thunderbird binaries (not sure how exactly building Lighting works). It look for some NSPR symbols in the wrong DLL (nss3.dll) when using Lightning in SeaMonkey. I guess we can enable MOZ_FOLD_LIBS for SeaMonkey, too. The change at http://hg.mozilla.org/comm-central/rev/adbc208dc608 was not actually necessary at that time btw if I recall correctly :) (Thunderbird tree had multiple issues at that time, so some things were tried to get the build running again).

Comment 7

[Stefan Sitter [:ssitter]]

Resolving as FIXED by the check-in of Bug 915574. Intentionally keeping this bug to retest and validate with specific Lightning builds when SeaMonkey changes for Bug 915574 are ported back to other branches.