915602 - [Bluetooth] Call sendFile api will crash the system while device is just paired.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[[e-mail], [e-mail]]

There is a scenario of sharing files via Bluetoooth inline pairing flow. It will immediately use sendFile() api while receiving 'onpairedstatuschanged' event with a paired device. At this timing, it will let the system crash.

Comment 1

[Eric Chou [:ericchou] [:echou]]

I've tried 6 times with the latest build on nexus 4 and couldn't reproduce.

= Build Info =
Gaia:master

commit 403637566676df775877013652e10d9a168edbd7
Author: Julien Wajsberg <[e-mail]>
Date:   Thu Dec 19 20:37:30 2013 +0100

Gecko:m-c

commit f0b5ead194a0b5b9ec26b2e67a9e4ffb2955f3e1
Merge: 9a43f7e d789f4b
Author: Wes Kocher <[e-mail]>
Date:   Tue Jan 21 17:27:53 2014 -0800

    Merge fx-team to m-c

= Note =
I modified apps/bluetooth/js/deviceList.js:

diff --git a/apps/bluetooth/js/deviceList.js b/apps/bluetooth/js/deviceList.js
index 5aacefe..413fff7 100644
--- a/apps/bluetooth/js/deviceList.js
+++ b/apps/bluetooth/js/deviceList.js
@@ -267,15 +267,19 @@ navigator.mozL10n.ready(function deviceList() {
           // the system while device is just paired.
           // The paired device is ready to send file.
           // Since above issue is existed, we use a setTimeout with 3 secs delay
+          /*
           var waitConnectionReadyTimeoutTime = 3000;
           setTimeout(function() {
             readyToSendFile(device);
           }, waitConnectionReadyTimeoutTime);
+          */
 
           var item = openList.index[workingAddress][1];
           openList.list.removeChild(item);
           delete openList.index[workingAddress];
           connectingAddress = workingAddress;
+
+          readyToSendFile(device);

(Please correct me if the 3 secs delay would still work in this case.)

Ian, would you mind trying again and see if this still doesn't work for you?

Comment 2

[Eric Chou [:ericchou] [:echou]]

Just want to take a note because it seems related to bug 962310.

Comment 3

[[e-mail], [e-mail]]

Eric,

I'm not able to reproduce the issue anymore. My test devices and version are as following.

===== Helix (repro rate 0/5) ===== 
Gaia:     2d11f1d52542cf48fb0da770f83644e5dec2e63e
Gecko:    http://hg.mozilla.org/mozilla-central/rev/3f1dd2a8e972
BuildID   20140126040203
Version   29.0a1

===== Inari (repro rate 0/5) =====
Gaia      2d11f1d52542cf48fb0da770f83644e5dec2e63e
Gecko     http://hg.mozilla.org/mozilla-central/rev/3f1dd2a8e972
BuildID   20140126040203
Version   29.0a1
ro.build.version.incremental=eng.cltbld.20140105.073001
ro.build.date=Sun Jan  5 07:53:36 EST 2014

I'll give a pr for removing the timeout workaround. It will make the sending flow more smooth. Thanks.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Ian,

Thanks. Resolved as WFM and remove bug 962310 from 'see also' list.