[B2G][Helix][OTA][ChenHoulai]After the update file is downloaded, it can not be installed when the network is close.

UNCONFIRMED
Unassigned

Status

Firefox OS
General
P2
blocker
UNCONFIRMED
4 years ago
2 years ago

People

(Reporter: lecky, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
Dependency tree / graph

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

(Whiteboard: [priority])

Attachments

(1 attachment)

45.30 KB, application/octet-stream
Details
(Reporter)

Description

4 years ago
Created attachment 803671 [details]
pic.rar

User Agent: Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; aff-kingsoft-ciba)

Steps to reproduce:

【Detail Description*】:After the update file is downloaded, it can not   be     installed when the network is close.
【Repro Steps*】:
   1、Enter into the settings, click 'check now' to get update info.
    2、Download the update file, when prompt install now or not, click 'later'.
    3、Close the network.
    4、Click the update info in the state bar to install the update file.
【Expect Result*】:
   1、The update file can be install normally.
【Real Result*】:
   1、The update file can not be install. Tip no network.
【Test Count*】:5
【Found Count*】:5
【Gaia commit ID*】:c0ea0a4943dc8d3751b07f5b5c5d3abe06364a14  
【Gecko commit ID*】: 170f9e477571127cd40997fa2abe262ed43f0e4d  
【Log*】:pic.rar
【Network environment】:
【Resume operation】:
【Carrier】:
(Reporter)

Updated

4 years ago
Severity: normal → blocker
blocking-b2g: --- → hd?
Priority: -- → P2
(Reporter)

Updated

4 years ago
Flags: needinfo?(wchang)
Is this on application update or system update?
Flags: needinfo?(wchang) → needinfo?(lecky.wanglei)

Updated

4 years ago
blocking-b2g: hd? → ---
(Reporter)

Comment 2

4 years ago
It is on system update.
Flags: needinfo?(lecky.wanglei)
(Reporter)

Updated

4 years ago
blocking-b2g: --- → hd?
Flags: needinfo?(wchang)
Kaizhen,

Can you check this here? The steps are quite clear so can you check the logic behind this?
Flags: needinfo?(wchang) → needinfo?(kli)
I don't think this is an issue. 

When "check now" is clicked, update services will try to connect the server to check new version. 

When network is down, update service can't make sure if the local update file is already the latest one. 

It will reschedule to check the update later when network is up and will not prompt to install the local update file.
Flags: needinfo?(kli)
(Reporter)

Comment 5

4 years ago
I think this is an issue.

The last step is 'Click the update info in the state bar', not 'click the check now'.

I track the process, the process does not connect the net to check anything. It just return in the downloadUpdate function of 'nsUpdateService.js' file. The concrete code is :
    if (!this._patch) {
      LOG("Downloader:downloadUpdate - no patch to download");
      return readStatusFile(updateDir);
    }

In this case, if you connect any wifi, even if the wifi can not connect to the ota server, the update file install will success. This also hint that the process does not connect the net to check anything. 

Please help to confirm. thanks.
(Reporter)

Updated

4 years ago
Flags: needinfo?(kli)
(Reporter)

Updated

4 years ago
Flags: needinfo?(wchang)
No point to need info me here.
Flags: needinfo?(wchang)
There are two parts in this case,
1. gaia will display the download information or warning message and send event to update service in gecko
2. update services in gecko will check and download update accordingly

So when there is no network, gaia will always display offline warning and will not display the download button.
Without the "download" button, it is not possible to redirect to "install" button.

To display the download button even when network is offline, need to patch this file
"gaia/apps/system/style/update_manager/update_manager.css"
Flags: needinfo?(kli)
(Reporter)

Comment 8

4 years ago
Will this problem be fixed on firefox os 1.1?
(Reporter)

Updated

4 years ago
Flags: needinfo?(kli)
Hi, Wayne, This case needs UX and gaia to provide a better experience, can you help on this?
Flags: needinfo?(kli) → needinfo?(wchang)
NI?UX

Currently if we have a update package downloaded successfully, it cannot be installed if no network connection is available.

It makes sense for users to be able to install the package even if network is not available as our target user are likely those who enable data on a need-to-use basis.
Flags: needinfo?(wchang) → needinfo?(firefoxos-ux-bugzilla)
As this is not a regression, we will not block on this for v1.1/hd.

nominating for koi? with my rationale in comment 10.
blocking-b2g: hd? → koi?
(Reporter)

Updated

4 years ago
Flags: needinfo?(brg)
we are fine with comment 11, thanks Wayne.
Flags: needinfo?(brg)

Comment 13

4 years ago
Flagging Carrie (UX) and Bruce (for product insight) on the expected behavior here.
Flags: needinfo?(firefoxos-ux-bugzilla)
Flags: needinfo?(cawang)
Flags: needinfo?(bhuang)
Wayne,

Sounds like it is a new feature request per comment 10.
Flags: needinfo?(wchang)
ni Neo, since this is about system update issue.
Flags: needinfo?(cawang) → needinfo?(nhsieh)
Preeti,

Not sure if this should be considered a feature request or if it should be considered an UX oversight on the initial design. I'd leave this to UX to decide.

For now it is OK for me if it doesn't make koi+ but I'd like to have UX review this.
Flags: needinfo?(wchang)

Comment 17

4 years ago
Why do we need network first ? Is there any flag or sign to let the system check if the download had already finished without network ?
Flags: needinfo?(nhsieh)
I would say the experience needs some polishing, if there are checks that still need network even when the package is downloaded we should give the appropriate indications.  I don't think this is a koi blocker, as there's probably a full UX revamp waiting to happen here.
Added to device backlog.
Blocks: 905001
Flags: needinfo?(bhuang)
Minus for now. Please renom if needed
blocking-b2g: koi? → -
blocking-b2g: - → backlog
Whiteboard: [priority]
(Assignee)

Updated

3 years ago
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog

Updated

2 years ago
Blocks: 1181775
You need to log in before you can comment on or make changes to this bug.