915825 - Have a better way to handle about:home visibility state with BrowserSearch

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

When keyboard is dismissed in BrowserSearch, at times about:home wasn't shown. This was fixed in Bug 911830, though a better cleanup is needed.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Why is the HomePager hidden in BrowserApp.filterEditingMode[1]? Doesn't browserSearch draw directly over the HomePager? If we don't change the visibility for the HomePager, we wouldn't need the band-aid in bug 911830.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/BrowserApp.java?rev=f1b97193d162#1529

Comment 2

[Sriram Ramasubramanian [:sriram]]

That's probably for overdraw problems I guess. Basically when someone is searching, we don't need to hold on to other fragments.

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Michael Comella (:mcomella) from comment #1)
> Why is the HomePager hidden in BrowserApp.filterEditingMode[1]? Doesn't
> browserSearch draw directly over the HomePager? If we don't change the
> visibility for the HomePager, we wouldn't need the band-aid in bug 911830.
> 
> [1]:
> https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/
> BrowserApp.java?rev=f1b97193d162#1529

This was added to avoid having the accessibility focus on the about:home views underneath the search results UI (see bug 906670).

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Semi-related idea: Perhaps we should be using an event system to handle view visibility changes with the LayerView/HomePager/BrowserSearch (e.g. "BrowserSearchHideEvent" would display the HomePager) as it seems particularly fragile now (I believe bug 929088 was caused by this fragility).

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: "contentArea" sample

Just so this doesn't get lost, lucasr came up with the idea of just updating what's displayed in the "contentArea" in a single function (rather than the event bus from comment 4) and wrote up this not entirely functional sample on the idea.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.