Closed Bug 915920 Opened 10 years ago Closed 10 years ago

APN values should only be updated once per phone boot

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:koi+)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g koi+

People

(Reporter: qdot, Assigned: aus)

References

Details

(Keywords: verifyme, Whiteboard: [systemsfe])

Attachments

(2 files, 1 obsolete file)

Patch - v2 - Ensure APN settings are only applied once per device boot-up.
46 bytes, text/x-github-pull-request
jaoo
: review+
Details | Review
Patch 2 (v1) - Fix quote issues in original commit
46 bytes, patch
jlal
: review+
Details | Diff | Splinter Review 
During updating Bug 891725, it was found that it may cause errors in multisim and hotswapping. We need to make sure we disconnect our listener after our first update.

Related to Bug 860411.
Whiteboard: [systemsfe]
Attachment #804142 - Attachment mime type: text/plain → text/html
Status: NEW → ASSIGNED
Comment on attachment 804142 [details]
Patch - v1 - Ensure APN settings are only applied once per device boot-up.

Filing addl review with jaoo since this was his work originally.
Attachment #804142 - Flags: review?(josea.olivera)
Attachment #804142 - Flags: review?(kyle) → review+
Comment on attachment 804142 [details]
Patch - v1 - Ensure APN settings are only applied once per device boot-up.

Leave a comment on the PR, please address the comment and request review at me again please. Thanks!
Attachment #804142 - Flags: review?(josea.olivera)
Depends on: 916044
Bug 916044 fixes the truncation issue.
Comment on attachment 804142 [details]
Patch - v1 - Ensure APN settings are only applied once per device boot-up.

re r?'ing jaoo for when Bug 916044 lands.
Attachment #804142 - Flags: review?(josea.olivera)

        Attachment #804142 -
        Attachment is obsolete: true

        Attachment #804142 -
        Flags: review?(josea.olivera)

        Attachment #804376 -
        Flags: review?(josea.olivera)

    
    

    
  
Comment on attachment 804376 [details] [review]
Patch - v2 - Ensure APN settings are only applied once per device boot-up.

Left a comment on the PR, take a look at it please.

        Attachment #804376 -
        Flags: review?(josea.olivera)

        Attachment #804376 -
        Flags: review?(josea.olivera)

    
    

    
  
Comment on attachment 804376 [details] [review]
Patch - v2 - Ensure APN settings are only applied once per device boot-up.

r=me

Thanks for the work and for your patient trying to understand all these tricky things.

        Attachment #804376 -
        Flags: review?(josea.olivera) → review+

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/604e110b1387fe868f39b392e039a57aea129ccc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Backed out due to gjslint issues.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

        Attachment #805055 -
        Flags: review?(jlal) → review+
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+
Attachment mime type: text/plain → text/x-github-pull-request
Keywords: verifyme

          You need to log in
          before you can comment on or make changes to this bug.