APN values should only be updated once per phone boot

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: qdot, Assigned: aus)

Tracking

({verifyme})

unspecified
x86
Mac OS X
verifyme

Firefox Tracking Flags

(blocking-b2g:koi+)

Details

(Whiteboard: [systemsfe])

Attachments

(2 attachments, 1 obsolete attachment)

During updating Bug 891725, it was found that it may cause errors in multisim and hotswapping. We need to make sure we disconnect our listener after our first update.

Related to Bug 860411.
Whiteboard: [systemsfe]
(Assignee)

Comment 1

5 years ago
Created attachment 804142 [details]
Patch - v1 - Ensure APN settings are only applied once per device boot-up.
Attachment #804142 - Flags: review?(kyle)
(Assignee)

Updated

5 years ago
Attachment #804142 - Attachment mime type: text/plain → text/html
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Comment on attachment 804142 [details]
Patch - v1 - Ensure APN settings are only applied once per device boot-up.

Filing addl review with jaoo since this was his work originally.
Attachment #804142 - Flags: review?(josea.olivera)
Comment on attachment 804142 [details]
Patch - v1 - Ensure APN settings are only applied once per device boot-up.

Leave a comment on the PR, please address the comment and request review at me again please. Thanks!
Attachment #804142 - Flags: review?(josea.olivera)
Comment on attachment 804142 [details]
Patch - v1 - Ensure APN settings are only applied once per device boot-up.

re r?'ing jaoo for when Bug 916044 lands.
Attachment #804142 - Flags: review?(josea.olivera)
Created attachment 804376 [details] [review]
Patch - v2 - Ensure APN settings are only applied once per device boot-up.
Attachment #804142 - Attachment is obsolete: true
Attachment #804142 - Flags: review?(josea.olivera)
Attachment #804376 - Flags: review?(josea.olivera)
Comment on attachment 804376 [details] [review]
Patch - v2 - Ensure APN settings are only applied once per device boot-up.

Left a comment on the PR, take a look at it please.
Attachment #804376 - Flags: review?(josea.olivera)
Comment on attachment 804376 [details] [review]
Patch - v2 - Ensure APN settings are only applied once per device boot-up.

r=me

Thanks for the work and for your patient trying to understand all these tricky things.
Attachment #804376 - Flags: review?(josea.olivera) → review+
Backed out due to gjslint issues.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 805055 [details] [diff] [review]
Patch 2 (v1) - Fix quote issues in original commit
Attachment #805055 - Flags: review?(jlal)
Attachment #805055 - Flags: review?(jlal) → review+
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+
Attachment mime type: text/plain → text/x-github-pull-request
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.