916041 - Add support for absolute-timestamped markers

Status: RESOLVED INVALID

(Core :: Gecko Profiler, defect)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

This allows b2g devs to sync up profile reports from different processes.

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Add absolute timestamp marker to GeckoProfiler

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

(The patch needs to be cleaned up--there's some junk in there--just looking for feedback on the idea.)

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Add absolute timestamp marker to GeckoProfiler, v2

Comment 4

[Benoit Girard (:BenWa)]

I'm currently working on a better way to do this in bug 914654. The merging magic happens in bug 915857 and I have another piece that I haven't posted yet to modify profile.sh to automate the merging. I think it should cover your use case better so let me know.

See the profile for a sample. Note that the histogram sync up. The processes/threads will be selectable via profile.sh:
http://people.mozilla.org/~bgirard/cleopatra/#report=65cfe559f92bf66da8aee49d147b2dfc26f29e40

Comment 5

[Mike Habicher [:mikeh] (high bugzilla latency)]

Your solution is much more elegant than mine--I eagerly await it's landing.

Comment 6

[Mike Habicher [:mikeh] (high bugzilla latency)]

*its landing (sigh)

Comment 7

[Benoit Girard (:BenWa)]

I wouldn't block on that. Apply the patch from 914658 and remove the ifdef GONK in mozilla_sampler_(un)register_thread.

Comment 8

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Add absolute timestamp marker to GeckoProfiler, b2g18 port

May as well keep this here, in case it comes in handy.

Comment 9

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Add absolute timestamp marker to GeckoProfiler, b2g18 port, v2

Comment 10

[Benoit Girard (:BenWa)]

Now you only have to remove the stuff in mozilla_sampler_(un)register_thread. Is this sufficient for you?

Comment 11

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Benoit Girard (:BenWa) from comment #10)
>
> Now you only have to remove the stuff in
> mozilla_sampler_(un)register_thread. Is this sufficient for you?

It should be. I'll switch to doing that once I'm done the tests I need to get done. Once I've pulled the profile logs, how do I merge them?

Comment 12

[Benoit Girard (:BenWa)]

When doing |profile.sh capture| if multiple processes are being profiled it will pull all profiles + generate a merged and synced up profile. Right now there's a small bug that require the main b2g process to be profiled for profile.sh capture to work but it's just a tiny bash logic bug that needs to be fixed.