916256 - Download arrow animation should animate to the overflow arrow if the download button has been overflowed

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

In Australis, if the download button has overflowed and is located in the overflow panel, new downloads don't have the arrow animation visible.

We should animate the arrow moving to the overflow panel so users will see where to click to find more information about their download.

Comment 1

[:Gijs (out for now; he/him)]

My impression from looking at the downloads button API is that this would be hard to do as the animation is currently in a XUL <stack> in the toolbarbutton. Marco, is that impression correct? Do you have any idea how we could do this instead?

Comment 2

[Marco Bonardo [:mak]]

I don't have a plan off-hand to move out the animation, but I think other bugs rely on that change, IIRC there are a couple bugs about the animation being cut-off by other pieces of the ui... so ideally we should overlay it to all the rest.
But as I said, I don't have a plan about how to do that.
All I can tell is that it's probably not a oneline trivial change.

Comment 3

[:Gijs (out for now; he/him)]

This should be pretty easy now that bug 922847 is fixed (essentially taking Marco's suggestion from comment #2). It should probably also overflow to the menupanel icon when that is not open and the button is in there.

It should ideally probably overflow to the icon in either panel if it *is* open, but I'm not sure if that'll "just work" or not. I suspect that because the animation stuff isn't inside the panel element, it might end up underneath the panel. I'll look into this on the train home from summit. If that fails, I think it's acceptable to always animate to the anchor of the panel (assuming that doesn't lead to a half-cut-off animation...).

Comment 4

[:Gijs (out for now; he/him)]

Attachment: download animation should anchor on panel anchor when the downloads button is in the panel,

So this works, sort of. If you add the downloads button as the last button in the panel, the animation causes the scrollbar to show up. I guess if you were to have a scrolling panel already (due to a lot of other buttons from e.g. add-ons, you wouldn't see it at all because the code would presume the element is 'visible', even though it's scrolled out of view. For this reason, and because the code is somewhat fragile as-is, I actually think we should do what the existing code does when the downloads panel itself is open: only animate onto the anchor, and only if the panel isn't showing. Does that sound reasonable?

Comment 5

[:Gijs (out for now; he/him)]

Attachment: download animation should anchor on panel anchor when the downloads button is in a panel,

This is a more basic patch, altwhich always uses the anchor if the button is in a panel. I only just noticed our anchor support doesn't deal well with areas that have not yet been built. Fix in this patch, I'll update the other patch in a sec.

Comment 6

[:Gijs (out for now; he/him)]

Attachment: download animation should use panel anchors or even nodes in panel,

Including the anchor fix this time.

Comment 7

[:Gijs (out for now; he/him)]

Comment on attachment 814099 [details] [diff] [review]
download animation should anchor on panel anchor when the downloads button is in a panel,

Per IRC discussion, leaving this one as r? and unobsolete.

Basically, the idea is, this patch always uses the anchors, and if the overflow/menu panel is open, doesn't display a notification, just like the button doesn't display a notification if its own panel is open.

The newer patch uses the anchors if the panel isn't open, and uses the button itself if the panel *is* open and visible. Which has the problems outlined in comment 4.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 814099 [details] [diff] [review]
download animation should anchor on panel anchor when the downloads button is in a panel,

Review of attachment 814099 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, I agree that we're probably OK to skip the animations if the button is in an open panel.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 814101 [details] [diff] [review]
download animation should use panel anchors or even nodes in panel,

Let's not do this one.

Comment 10

[:Gijs (out for now; he/him)]

https://hg.mozilla.org/projects/ux/rev/aa03fbc1149f

Comment 11

[:Gijs (out for now; he/him)]

https://hg.mozilla.org/mozilla-central/rev/aa03fbc1149f