91630 - PAC: "PROXY hostname" should assume a default port

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Chase Tingley]

Comments from bug 79893:

------- Additional Comments From Andrew Smith 2001-07-20 01:35 -------

Our company's PAC has *never* worked with Mozilla, and I've only just worked out
why. It basically looks like this:

function FindProxyForURL(url, host)
{
	if(isPlainHostName(host))
		return "DIRECT";
	else if(shExpMatch(host, "*.special-internal.com"))
		return "PROXY webproxy";
	else if(shExpMatch(host, "*.normal-internal.com"))
		return "DIRECT";
	else
		return "PROXY webproxy";
}

Mozilla just spins every time it should be hiting the proxy. But it looks fine,
and works under NN4 and IE4/5. Only after reading the PAC spec linked to in bug
91121 did I work out that the "PROXY webproxy" should strictly speaking be
"PROXY webproxy:80" even though 80 is the default HTTP port. I've made this
change to a local copy and it fixes the problem under 0.9.2.

So, either this requires a new bug for backwards/sidewards compatability, or it
needs documenting so the rest of the world can catch up. I don't think the
latter will make Mozilla many friends in the corporate world. :)

Comment 1

[Chase Tingley]

The PAC "spec" at 
  http://home.netscape.com/eng/mozilla/2.0/relnotes/demo/proxy-live.html
claims to require "PROXY host:port", but reporter is claiming 4xp so I'm marking
it that way.

If this is something we should support I can roll it into the patch for bug
84798, which is touching the same line of code that causes this problem.

Comment 2

[Doug Turner (:dougt)]

-> serge

Comment 3

[benc]

+ RELNOTE:

"Using a "PROXY" directives had a default port of 80" in Communicator. This was
incorrect. Mozilla requires you specfy a port (e.g. PROXY servername:8080).

Comment 4

[Bradley Baetz (:bbaetz)]

*** Bug 94216 has been marked as a duplicate of this bug. ***

Comment 5

[Chase Tingley]

Attachment: fix

Comment 6

[Chase Tingley]

*sigh*

Every morning I wake and want to mark this WONTFIX, and then I see that '4xp'
staring back at me...

Since we've got a second report of this now, I cooked up a simple fix. 

Comment 7

[benc]

Its a lesson to anyone that ships software while pretending they don't have to
own the behavior as a clearly described document.

Comment 8

[Chase Tingley]

Postponing review-seeking until Serge finishes hacking up this same code for bug
84798.

Comment 9

[Chase Tingley]

This was included as part of basic's fix for bug 105335.

Comment 10

[benc]

*** Bug 121038 has been marked as a duplicate of this bug. ***