916319 - Only show t-shirt sizes on profiles to privileged users

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[William Reynolds [:williamr]]

Attachment: T-shirt size visible to all Mozillians.png

The t-shirt field is on our stage environment, and it displays a user's shirt size on their profiles for all Mozillians who view that profile. Instead, we want the shirt size to only be visible to privileged users. For now, privileged users is the same as admin users. We may add more privileged users later.

Expected results: Only priviliged users (admin users) can view the t-shirt size on the profile for a user.
Actual results: All vouched users can view the t-shirt size on the profile for a user. Screenshot attached.

Suggested implementation: If you are not a priviliged user, you will not see the "T-Shirt Size:" label and value on another user's profile.

Comment 1

[Andrei [:sancus]]

This is actually a release blocker because the field is revealed to the public. Fixed, though, in https://github.com/mozilla/mozillians/pull/610

Also, privileged users are a System group that admin can add arbitrary people to via the group interface, and after this patch, admin are privileged by default as well.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/475c1736f917f266e3c96dce628292c20f170f20
[Fix Bug 916319] Only show t-shirt sizes to privileged users and make admin privileged by default

https://github.com/mozilla/mozillians/commit/215bfe50886a6ad28e624e90dc603eb35cbfe953
Merge pull request #610 from Sancus/tshirtprivacy

[Fix Bug 916319] Only show t-shirt sizes to privileged users and make admin privileged by default

Comment 3

[William Reynolds [:williamr]]

Verified that regular users cannot see the t-shirt sizes for other users. Admins and those in the privileged group can.