916383 - Invisible autocomplete items selectable by keyboard when "your results" not shown

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Firefox Start, defect)

Description

[Rodrigo Silveira [:rsilveira] [:rodms]]

STR:
- Type some letters in the url bar and see items populated in "your results" section of autocomplete popup
- Keep typing garbage until "your results" is empty.
- Press down key multiple times and notice that once you've iterated through every item you have to press the down key multiple times to cycle through.

When we detect that there was no results we just hide the grid, keeping whatever was there last. Those ghost items are still selectable by keyboard.

Comment 1

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v1

Removes lingering results when none was found.

Comment 2

[Rodrigo Silveira [:rsilveira] [:rodms]]

Will add a test for this.

Comment 3

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: 916383_tests.patch

Test for the bug. Verified that fails without patch and passes with the fix.

Comment 4

[Rodrigo Silveira [:rsilveira] [:rodms]]

https://hg.mozilla.org/integration/fx-team/rev/d827810f4132

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d827810f4132

Comment 6

[Rodrigo Silveira [:rsilveira] [:rodms]]

https://hg.mozilla.org/integration/fx-team/rev/7a9e49f45e50

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7a9e49f45e50