916577 - Disabling the Social API should remove the Services tab in about:addons

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, enhancement)

Description

[der_tuxman]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:24.0) Gecko/20130911 Firefox/24.0 PaleMoon/24.0 (Nightly/Aurora)
Build ID: 20130911003217

Steps to reproduce:

I changed the social.enabled prefs setting to false.


Actual results:

The Social API was disabled, the Services tab in about:addons still remains visible for no obvious reason - it makes no sense anyway when social.enabled is false.


Expected results:

The Services tab should disappear.

Comment 1

[sjw]

Thanks for your report and sorry for answering so late. Can you still reproduce this bug?

Comment 2

[der_tuxman]

Yes, Firefox beta still has this issue.

Comment 3

[sjw]

The tab is not shown here. Have you installed an extension before?

Comment 4

[Mark Straver]

I can confirm the Services tab always shows, even if you've never used the social API before or have never installed a service add-on, or have the social API completely enabled in about:config as stated in comment 0

The tab shows a blank page with "You don't have any add-ons of this type installed" and is otherwise not used if you don't use the social API. If the API is explicitly disabled, the tab serves absolutely no purpose, ever, so should indeed not be shown, IMHO.

Comment 5

[Shane Caraveo (:mixedpuppy)]

social.enabled is being removed as a pref in bug 894806 and social will be enabled if there is one enabled social provider installed.  The social tab should only appear if there are any installed social providers, as other tabs (e.g. themes).

Comment 6

[Shane Caraveo (:mixedpuppy)]

Attachment: hide service tab in about:addons

this hides the service tab if no providers are installed

Comment 7

[Mike Kaply [:mkaply]]

Shane:

Shane:

Should this get checked in?

Comment 8

[Shane Caraveo (:mixedpuppy)]

It could.  It breaks at least one test, so there is some work to be done...

Comment 9

[Mike Kaply [:mkaply]]

FYI, the failing test is browser_social_activation.js although I don't totally understand why it's failing.

Comment 10

[Mike Kaply [:mkaply]]

So the problem is here:

https://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/social/browser_social_activation.js#232

The test navigates to addons://list/service, but since that page doesn't exist anymore, it defaults to the first page. So then later on in the test when they try to remove the social provider, it doesn't work.

After activating the provider, we need to switch the addons manager to the services tab. I tried BrowserOpenAddonsMgr('addons://list/service'); but that opens a new window and breaks things.

Comment 11

[Andrew Swan [:aswan]]

I don't have the bug # handy but the social api has been removed

Comment 12

[Mark Straver]

It would be very helpful to know the bug# for removal of the social API. I did a search but came up with zilch.

Comment 13

[Andy McKay]

See bug 1388902.