1388902 - Shut down the last of socialapi

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, enhancement)

Description

[Shane Caraveo (:mixedpuppy)]

The last element of SocialAPI, Share, is growing into a state of disrepair.  Now that webextensions are capable of reproducing what Share is, we'll just remove the last bits and maybe find time to implement Share as a webextension pageAction.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1388902 remove socialapi share,

Review commit: https://reviewboard.mozilla.org/r/166778/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166778/

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8895580 [details]
Bug 1388902 remove socialapi share,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166778/diff/1-2/

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8895580 [details]
Bug 1388902 remove socialapi share,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166778/diff/2-3/

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8895580 [details]
Bug 1388902 remove socialapi share,

https://reviewboard.mozilla.org/r/166778/#review173022

::: browser/themes/shared/menupanel.inc.css
(Diff revision 3)
>  /* Menu panel and palette styles */
>  
> -#add-share-provider {
> -  list-style-image: url(chrome://browser/skin/menuPanel-small.svg);

This makes menuPanel-small.svg unused, please remove it (browser_all_files_referenced.js will fail if you don't.)

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8895580 [details]
Bug 1388902 remove socialapi share,

https://reviewboard.mozilla.org/r/166778/#review173032

::: browser/base/content/browser.js:36
(Diff revision 3)
>            PluralForm:false, PrivateBrowsingUtils:false,
>            ProcessHangMonitor:false, PromiseUtils:false, ReaderMode:false,
>            ReaderParent:false, RecentWindow:false, SafeBrowsing: false,
>            SessionStore:false,
>            ShortcutUtils:false, SimpleServiceDiscovery:false, SitePermissions:false,
> -          Social:false, TabCrashHandler:false, TelemetryStopwatch:false,
> +          TabCrashHandler:false, TelemetryStopwatch:false,

You probably know it already, but bug 1388215 removed this comment.

::: browser/base/content/nsContextMenu.js:388
(Diff revision 3)
> -                    this.onImage || this.onVideo || this.onAudio || this.onSocial ||
> +                    this.onImage || this.onVideo || this.onAudio ||
>                      this.onCanvas || this.inWebExtBrowser));
>      bookmarkPage.setAttribute("tooltiptext", bookmarkPage.getAttribute("buttontooltiptext"));
>  
>      this.showItem("context-bookmarklink", (this.onLink && !this.onMailtoLink &&
> -                                           !this.onSocial && !this.onMozExtLink) ||
> +                                          !this.onMozExtLink) || this.onPlainTextLink);

nit: the indent is 1 space less than it should be on this line.

Comment 6

[Francesco Lodolo [:flod]]

Does it mean that we should get rid of the Social API project on Pontoon?
https://github.com/mixedpuppy/socialapi-directory

Comment 7

[Shane Caraveo (:mixedpuppy)]

(In reply to Francesco Lodolo [:flod] (traveling, slow reply until Aug 18) from comment #6)
> Does it mean that we should get rid of the Social API project on Pontoon?
> https://github.com/mixedpuppy/socialapi-directory

Yes, after this has landed.

Comment 8

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8895580 [details]
Bug 1388902 remove socialapi share,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166778/diff/3-4/

Comment 9

[Florian Quèze [:florian]]

Comment on attachment 8895580 [details]
Bug 1388902 remove socialapi share,

https://reviewboard.mozilla.org/r/166778/#review174480

Please remove the debugging code in:
caps/BasePrincipal.cpp 	
caps/nsScriptSecurityManager.cpp 	
docshell/base/nsDocShell.cpp 	
dom/security/nsContentSecurityManager.cpp 	
netwerk/base/SimpleChannelParent.cpp 	
netwerk/base/nsBaseChannel.cpp

Looks good otherwise :-)

Comment 10

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8895580 [details]
Bug 1388902 remove socialapi share,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166778/diff/4-5/

Comment 11

[Florian Quèze [:florian]]

Comment on attachment 8895580 [details]
Bug 1388902 remove socialapi share,

https://reviewboard.mozilla.org/r/166778/#review174508

Thanks!

Comment 12

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8895580 [details]
Bug 1388902 remove socialapi share,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166778/diff/5-6/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57e52be85a1a
remove socialapi share, r=florian

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/57e52be85a1a

Comment 15

[Kohei Yoshino]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2017/social-api-has-been-completely-removed/

Comment 16

[:Gijs (he/him)]

Release Note Request (optional, but appreciated)
[Why is this notable]: The "Share" button disappeared, and this is confusing for users who used this functionality. (cf. bug 1391311 comment 0)
[Affects Firefox for Android]: I don't know.
[Suggested wording]: The "Share" button was removed. You can now use the [page action menu](link to sumo) to quickly copy or email page links to people.

Note: this should be updated to refer to the explicit OS share functionality integration if/when bug 1363169 and friends get fixed.
[Links (documentation, blog post, etc)]: I don't have one. Maybe Shane wants to write one?

Comment 17

[Kohei Yoshino]

I think it would be nice to have a migration path to webextensions so people won't be surprised or angry when 57 is out. Some have already noticed this on Nightly. Any plans?

Comment 18

[Daniele "Mte90" Scasciafratte]

I use that feature a lot (the share), I use privacy badger so I disabled everywhere the social buttons but in the browser are more comfortable (speed) but without a replacement I feel very abandoned.
It was only a popup with the share of every social network already filled with url and title.
There any plans for an extension?

Comment 19

[Liz Henry (:lizzard) (relman/hg->git project)]

This add-on was mentioned as having good share functionality: https://addons.mozilla.org/en-US/firefox/addon/addtoany-share/?src=search   I haven't tried it but you may want to give it a shot. There are probably others that add a share button to the browser. Hope that helps.

Comment 20

[Daniele "Mte90" Scasciafratte]

I tried that addon but with my permission about do not track, privacy badger and my /etc/hosts file that block websites that track etc whit extension doesn't work.

Comment 21

[Daniele "Mte90" Scasciafratte]

I have done an extension that reimplement the feature of the modal to share of Firefox share not available anymore on firefox nightly 57. Now we have only to wait the review :-)

https://addons.mozilla.org/it/firefox/addon/share-backported/

Comment 22

[Pascal Chevrel:pascalc]

(In reply to Daniele "Mte90" Scasciafratte from comment #21)
> I have done an extension that reimplement the feature of the modal to share
> of Firefox share not available anymore on firefox nightly 57. Now we have
> only to wait the review :-)
> 
> https://addons.mozilla.org/it/firefox/addon/share-backported/

The extension is now published, thanks Daniele. We can propose this web extension as a migration path in the Nightly release notes.

Comment 23

[Shane Caraveo (:mixedpuppy)]

[Affects Firefox for Android]: Firefox
[Suggested wording]: The "Share" button was removed. New extensions can implement share functionality using a page action.  Daniele Scasciafratte has provided a replacement extension at https://addons.mozilla.org/it/firefox/addon/share-backported/

Maybe something like that.

Comment 24

[Francesco Lodolo [:flod]]

In case, make sure to use a locale agnostic link https://addons.mozilla.org/firefox/addon/share-backported/

Comment 25

[Chris Mills [:cmills]]

I have moved all the Social API documentation to the MDN archive:

https://developer.mozilla.org/en-US/docs/Archive/Social_API

I've also added a note to the Fx57 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/57#APIs_2

Let me know if that's OK. Thanks!

Comment 26

[Anna]

There are 4 left-over 'social.*' prefs which can now get removed as well:

https://dxr.mozilla.org/mozilla-esr52/source/modules/libpref/init/all.js#4938


'social.toast-notifications.enabled' is definitely not used anymore:

https://dxr.mozilla.org/mozilla-esr52/search?q=toast-notifications
https://dxr.mozilla.org/mozilla-release/search?q=toast-notifications
https://dxr.mozilla.org/mozilla-beta/search?q=toast-notifications
https://dxr.mozilla.org/mozilla-central/search?q=toast-notifications

it was still used in ESR45 (https://dxr.mozilla.org/mozilla-esr45/search?q=toast-notifications) but was removed in 1289549

Same for 'social.whitelist'


'social.directories':

still some code in ESR45 + ESR52 + Release (56) but removed in Beta 57 with this ticket:

https://dxr.mozilla.org/mozilla-esr45/search?q=social.directories
https://dxr.mozilla.org/mozilla-esr52/search?q=social.directories
https://dxr.mozilla.org/mozilla-release/search?q=social.directories

https://dxr.mozilla.org/mozilla-beta/search?q=social.directories


Same for 'social.remote-install.enabled'

Comment 27

[Anna]

Sorry the 1st link should have been to mozilla-central:
https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.js#5226

Comment 28

[Anna]

"social.enabled" can also be removed in https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/Troubleshoot.jsm#88

Comment 29

[Shane Caraveo (:mixedpuppy)]

new bugs for additional work please.

Comment 30

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This was added to Beta 57 release notes.