916593 - YouTube and Vimeo iframes, no Flash plug-in; navbar shows a plug-in icon and a Click-to-play icon, CtP doorhanger is broken

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect, P3)

Description

[[:Aleksej]]

Attachment: screenshot

Steps to reproduce:
1. Have no Flash plug-in installed.
2. Load http://wardcunningham.github.io/
-> The navigation bar gets two brick icons:
   * the one on the left has no down arrow, that's the CtP icon,
   * the one on the right has a down arrow, that's the Flash icon.
-> A Flash installation doorhanger appears.  Ignore it.
3. Dismiss the Flash installation doorhanger.
4. Click the button w/o a down arrow.
-> A broken doorhanger appears (see screenshot).  It has:
   * a close button;
   * a [Show All] button (it changes the doorhanger to a dialog asking "Allow wardcunningham.github.io to run plugins?");
   * two buttons so blank they are vertically narrow (they seem to do nothing).

Comment 1

[[:Aleksej]]

The second icon and the bug first appear between these builds:
wfm: 2013-07-19-03-02-04-mozilla-central-firefox-25.0a1.en-US.linux-x86_64
bug: 2013-07-20-03-02-14-mozilla-central-firefox-25.0a1.ru.linux-x86_64

https://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2013-07-19+02%3A00&enddate=2013-07-20+03%3A03

Comment 2

[Georg Fritzsche [:gfritzsche]]

On OS X i only see the click-to-play notification pop in for a short time.
On [1] i only see the missing-plugin notification, so something must be different about that page - my guess is some dynamic plugin insertion/removal by the embedding scripts for those videos.

FWIW, looks like triggered by one of: bug 888292, bug 889788, bug 887088, bug 888908.

[1] http://benjamin.smedbergs.us/tests/ctptests/flash-solo.html
[2] http://wardcunningham.github.io/

Comment 3

[Benjamin Smedberg]

There's a couple weird things going on here: 
* currently, when Flash is not installed the CtP icon and doorhanger aren't supposed to be present at all
* Bug 889788 was supposed to prevent this broken UI from showing

Is there anything in the error console (control-shift-J)?

Comment 4

[[:Aleksej]]

Excluding Net (there are no warnings or errors except for favicon 404s) and CSS,

when the page is loading, a "The character encoding of the HTML document was not declared." warning appears, then the doorhanger and the icons.


In a few seconds, 2 or 3 of these appear, referring to YouTube's html5player-vflGNj…:

TypeError: a is null

Comment 5

[Paul Silaghi, QA [:pauly]]

(In reply to Georg Fritzsche [:gfritzsche] from comment #2)
> so something must be different about that page
Sometimes http://wardcunningham.github.io/ completely freezes my FF on Win.

Comment 6

[Georg Fritzsche [:gfritzsche]]

(In reply to Paul Silaghi [QA] from comment #5)
> Sometimes http://wardcunningham.github.io/ completely freezes my FF on Win.
With Flash installed and allowed on that site i assume?
Freezes "for some time" or indefinitely? If indefinitely we should look at this in a new bug.

Comment 7

[Paul Silaghi, QA [:pauly]]

(In reply to Paul Silaghi [QA] from comment #5)
> Sometimes http://wardcunningham.github.io/ completely freezes my FF on Win.
Freezes indefinitely with Flash uninstalled. It happens only on nightly 26, works fine in 24, 25.
Also, no freeze with Flash installed.

Comment 8

[Georg Fritzsche [:gfritzsche]]

(In reply to Paul Silaghi [QA] from comment #7)
> (In reply to Paul Silaghi [QA] from comment #5)
> > Sometimes http://wardcunningham.github.io/ completely freezes my FF on Win.
> Freezes indefinitely with Flash uninstalled. It happens only on nightly 26,
> works fine in 24, 25.
> Also, no freeze with Flash installed.

Can you please file a new bug on this then? If you can, please get a crash report by killing it or using crashfirefox.exe [1] when it's frozen.

[1] http://benjamin.smedbergs.us/crashfirefox.exe

Comment 9

[Andreas Wagner [:TheOne] [use NI]]

Attachment: win.png

I can confirm this in latest aurora on Windows.

STR:

1. Login to feedly.
2. Open an article that has an embedded youtube video.
3. Click on "Home" in the left sidebar.

Comment 10

[Andreas Wagner [:TheOne] [use NI]]

By the way, I have the flash plugin installed and activated!

Comment 11

[Georg Fritzsche [:gfritzsche]]

With Flash installed and the site using iframes to embed videos this should be bug 922349.