916660 - (app-modal-dialog) [Window Management] refactor modal dialog, attach to appWindow

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

Just as current appError class, attach the modal dialog to appWindow and then we won't need to maintain the origin info anymore. And we could remove the DOM of modal dialog from index.html to reduce load time.

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

This would be done in bug 907013. Need finetune here

Comment 2

[[e-mail]]

The weird thing is I referenced index.html and change class from 'confirm' back to 'affirmative', it make crash....

Comment 3

[[e-mail]]

Attachment: pull request redirect to github

1. move elementClasses to similar structure of app_authentication_dialog,
2. simplify html render tags

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8347117 [details] [review]
pull request redirect to github

Please do the opposite:
Move element-fetch into _fetchElements and remove render.

Comment 5

[[e-mail]]

Comment on attachment 8347117 [details] [review]
pull request redirect to github

updated, please kindly review it again

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8347117 [details] [review]
pull request redirect to github

Pay attention to travis

Comment 7

[[e-mail]]

rebase and check result ok

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/2459080fde148b241ce46378a7009676a244ed47