Bug 916660 (app-modal-dialog)

[Window Management] refactor modal dialog, attach to appWindow

RESOLVED FIXED

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: alive, Assigned: gasolin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Just as current appError class, attach the modal dialog to appWindow and then we won't need to maintain the origin info anymore. And we could remove the DOM of modal dialog from index.html to reduce load time.
Assignee: nobody → gduan
Component: Gaia::System → Gaia::System::Window Mgmt
No longer blocks: task-manager
This would be done in bug 907013. Need finetune here
Alias: app-modal-dialog
Assignee: gduan → alive
The weird thing is I referenced index.html and change class from 'confirm' back to 'affirmative', it make crash....
Assignee: alive → gasolin
Summary: [Window Management] Rewrite modal dialog, attach to appWindow → [Window Management] refactor modal dialog, attach to appWindow
1. move elementClasses to similar structure of app_authentication_dialog,
2. simplify html render tags
Attachment #8347117 - Flags: review?(alive)
Comment on attachment 8347117 [details] [review]
pull request redirect to github

Please do the opposite:
Move element-fetch into _fetchElements and remove render.
Attachment #8347117 - Flags: review?(alive)
Comment on attachment 8347117 [details] [review]
pull request redirect to github

updated, please kindly review it again
Attachment #8347117 - Flags: review?(alive)
Comment on attachment 8347117 [details] [review]
pull request redirect to github

Pay attention to travis
Attachment #8347117 - Flags: review?(alive) → review+
Blocks: 950583
rebase and check result ok

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/2459080fde148b241ce46378a7009676a244ed47
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.