Closed
Bug 916732
Opened 11 years ago
Closed 11 years ago
PanelUI should have dedicated show() API
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: Unfocused, Assigned: Unfocused)
References
Details
Attachments
(1 file, 1 obsolete file)
|
4.31 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
At the moment, PanelUI has hide() and toggle() - and toggle() is dependent on coming from an event. This makes it awkward for outside code to use. there should be a dedicated show() method that doesn't require an event.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #805251 -
Flags: review?(gijskruitbosch+bugs)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 805251 [details] [diff] [review]
916732.diff
Generally, this looks good. Should show() check if it's already open? Hide's hidePopup() call will probably just no-op. It currently doesn't look like calling show() twice would be a problem, but maybe we should ensure that that doesn't cause problems we either don't suspect or could crop up later? (see e.g. bug 893994)
Attachment #805251 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 805251 [details] [diff] [review]
916732.diff
r-'ing at Blair's request over IRC to ensure that this still gets a check to not show() twice.
Attachment #805251 -
Flags: review+ → review-
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #805251 -
Attachment is obsolete: true
Attachment #814294 -
Flags: review?(gijskruitbosch+bugs)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 814294 [details] [diff] [review]
Patch v1
Review of attachment 814294 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM! :-)
Attachment #814294 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Whiteboard: [fixed-in-ux]
|
|
||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-ux]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•