917275 - HTTP cache v2: audit using old cache service here and there

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Honza Bambas (:mayhemer)]

It's few gum merges back I've last checked where all the old cache service is used.  Few new test were added that might use the old cache service as well as I could just miss some existing.

Tests and code touching only offline cache may remain on the old cache API for now, we are not changing offline cache implementation.

Blocking bug 913807 since the migration could potentially (however unlikely that would be) uncover an issue in the wrapping code that must work 100% correctly for 913807.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: part1 v1

I've found only one use that should be fixed, in a test.  Almost not even worth of a review time...

Nothing else serious has been found, all other use is related to offline cache only or to wyciwyg (bug 917423) or webapps data clear (bug 917432).

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: part2 v1

- changes the hook to "webapps-clear-data" to use the new API
- enables test_cache_jar.js
- see bug 917487 c1 when doing the review

This falls in this bug's scope as well.  It proves the API works as expected.  

On the other hand, this change is not critically needed for preff'ed of landing and will be refactored in bug 917432 anyway.  I've only checked that netwerk/test/unit/test_cache_jar.js works with this change with both the new and old cache.

Michal, what do you think?  Take it or not?  I actually just want to save your review time here...

Comment 3

[Honza Bambas (:mayhemer)]

https://tbpl.mozilla.org/?tree=Try&rev=bd8ad7d2e8ca

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 806165 [details] [diff] [review]
part1 v1

Landed on gum as https://hg.mozilla.org/projects/gum/rev/939999e3d8f6

Comment 5

[Honza Bambas (:mayhemer)]

Comment on attachment 806222 [details] [diff] [review]
part2 v1

Landed on gum as https://hg.mozilla.org/projects/gum/rev/e955ab4511d0