917432 - HTTP cache v2: hook to "webapps-clear-data" notification

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Honza Bambas (:mayhemer)]

See nsHttpHandler::Observe()

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: WIP1

This is a WIP to check we can do it with the new API.  The patch might be added to bug 917275, as I'm thinking of it.

However, I think this doesn't belong to the nsHttpHandler any more.  This needs to move to CacheObserver.

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: v1

- correct hook to web-apps-clear-data inside the new cache code
- however, still doesn't delete data on disk:

  EvictionRunnable(nsCSubstring const & aContextKey, TCacheEntryTable* aEntries,
  ...
  NS_IMETHOD Run()
  {
    LOG(("EvictionRunnable::Run [this=%p, disk=%d]", this, mUsingDisk));
    if (CacheStorageService::IsOnManagementThread()) {
      if (mUsingDisk) {
        // TODO for non private entries:
        // - rename/move all files to TRASH, block shutdown
        // - start the TRASH removal process
        // - may also be invoked from the main thread...
      }

We need a plan also on deleting individual files by certain criteria.

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 810021 [details] [diff] [review]
v1

This shows up being a regular fix.  Deleting individual files should be handled in a different bug (the eviction or index bug).

Needs a more careful review this time, some of the default running code is modified.

Comment 4

[Honza Bambas (:mayhemer)]

I have an updated patch already.  Will submit tomorrow.

Comment 5

[Honza Bambas (:mayhemer)]

Attachment: v2

Changes from v1:
- if a URL scheme is not one of http,ftp,wiciwyg, then the URL scheme is used as session name ; v1 was assert(false)'ing

Comment 6

[Honza Bambas (:mayhemer)]

Comment on attachment 813756 [details] [diff] [review]
v2

Here is a try run of stack of patches for:
bug 922659
bug 922671
bug 922741
bug 917432 (this one)

https://tbpl.mozilla.org/?tree=Try&rev=b830b18e9c1c

and is green for cache2 disabled :)

Comment 7

[Honza Bambas (:mayhemer)]

Attachment: v2 [merged]

- same as previous v2, just merged

Comment 8

[Honza Bambas (:mayhemer)]

Attachment: v3

- cleanup of GetCacheSessionNameForStoragePolicy ; using sessionName.Assign(NS_LITERAL_CSTRING()) which is the fastest way of assigning a literal
- schemes other then http, wyciwyg or ftp are using session name 'other' or 'other-private' + appid/in-browser jar
- this allows the new API to consistently delete any user data inside a defined load context (correct cache partitioning according the new api) even with cache2 off

cache2 on:  https://tbpl.mozilla.org/?tree=Gum&rev=ae6d25ad7724
cache2 off: https://tbpl.mozilla.org/?tree=Try&rev=7b66d8eaea88

Comment 9

[Honza Bambas (:mayhemer)]

Comment on attachment 831057 [details] [diff] [review]
v3

https://hg.mozilla.org/integration/mozilla-inbound/rev/66a063b14ddb
https://tbpl.mozilla.org/?tree=Try&rev=69d73cf7f79a

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/66a063b14ddb