917370 - large dependency trees are very slow to load

Status: RESOLVED FIXED

(Bugzilla :: Dependency Views, defect)

Description

[:glob ✱]

the dependency tree on bug 841999 is slow to the point of being useless (just took 45 seconds to load).

i suspect we can do better.

Comment 1

[:glob ✱]

Attachment: 917370_1.patch

there were two major problems with the old code performance-wise:
- it always generated bugs for the complete tree, regardless of max-depth
- it created bug objects one-by-one instead of using new_from_list

this patch greatly improves performance for bugs with deep dependency trees.

Comment 2

[Frédéric Buclin]

Comment on attachment 806146 [details] [diff] [review]
917370_1.patch

>-local our $hide_resolved = $cgi->param('hide_resolved') ? 1 : 0;
>-
>-local our $maxdepth = $cgi->param('maxdepth') || 0;
>-if ($maxdepth !~ /^\d+$/) { $maxdepth = 0 };
>+my $hide_resolved = $cgi->param('hide_resolved') ? 1 : 0;
>+my $maxdepth = $cgi->param('maxdepth') || 0;

You cannot use "my" and then use these variables inside subroutines (unless you pass them as parameters), see bug 348923.

Comment 3

[:glob ✱]

Attachment: 917370_2.patch

oops, thanks for catching that lpsolit.  that script is in need of a rewrite, but not today.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 806429 [details] [diff] [review]
917370_2.patch

Review of attachment 806429 [details] [diff] [review]:
-----------------------------------------------------------------

I am getting a lot of duplicates lines within the same block when going above depth of 5 or so. On your bmo/4.2 devel system, place the patched showdependencytree.cgi from trunk over the bmo copy.
Then view showdependencytree.cgi?id=841999&hide_resolved=1 and you will see what I mean. I will also attach a screenshot. dkl

Comment 5

[David Lawrence [:dkl]]

Attachment: screen shot showing duplicate dependencies for one bug

Comment 6

[:glob ✱]

Attachment: 917370_3.patch

Comment 7

[David Lawrence [:dkl]]

Comment on attachment 812476 [details] [diff] [review]
917370_3.patch

Review of attachment 812476 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl with fix on checkin.

::: showdependencytree.cgi
@@ +136,5 @@
>  }
> +
> +sub _get_dependencies {
> +    my ($bug_id, $relationship) = @_;
> +    my $cache = Bugzilla->request_cache->{dependency_cache};

Change the above line to:

my $cache = Bugzilla->request_cache->{dependency_cache} ||= {};

Otherwise, it would time out and the page never loaded for me.

Comment 8

[Frédéric Buclin]

Should be committed asap (with the fix on checkin) as we plan to release on Tuesday.

Comment 9

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified showdependencytree.cgi
Committed revision 8619.

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified showdependencytree.cgi
Committed revision 8773.

Comment 10

[Asa Dotzler [:asa]]

AWESOME!!!  This is so much better now. Thank you all for your quick attention and for the great fix!