917479 - Starting a simulator changes host and port settings

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Right now, there's only one set of host and port settings in the connection footer.

If you start a simulator, the port will likely change to a randomly chosen port at startup time.  If you later want to connect to a device, you'll have to edit the port back to 6000 first, then connect.

Generally, it feels like we may need to rethink the flow of the connection footer to make it simpler to preserve the device settings.

Comment 1

[Paul Rouget [:paul]]

If you re-use the connection used by the Simulator, indeed.

When the simulator closes, we should kill the connection as well, and create a new one.

Comment 2

[Paul Rouget [:paul]]

(not critical for 26)

Comment 3

[Paul Rouget [:paul]]

Attachment: Patch v1

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 810563 [details] [diff] [review]
Patch v1

Needs rebase, connected listener in now a singleton.

Comment 5

[Alexandre Poirot [:ochameau]]

The conflicting patch is the one from bug 919681.

Comment 6

[Paul Rouget [:paul]]

Attachment: Patch V2

Comment 7

[Alexandre Poirot [:ochameau]]

Comment on attachment 811116 [details] [diff] [review]
Patch V2

Review of attachment 811116 [details] [diff] [review]:
-----------------------------------------------------------------

FYI: If you launch the simulator and immediatly click on cancel, it doesn't reset to 6000.
Otherwise, the patch works fine in sane usages of the simulator.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/d079bd51114c

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d079bd51114c

Comment 10

[Paul Rouget [:paul]]

Comment on attachment 811116 [details] [diff] [review]
Patch V2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: connection params messed up after simulator started
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/90ad9f7c9795

Comment 12

[Manuela Muntean [Away]]

Verified as fixed with: latest Aurora 27.0a2, latest Nightly 28.0a1 and latest Beta 26 beta 4, on: Win 7 32-bit, Ubuntu 13.04 32-bit, Mac OS X 10.6.8