Closed Bug 917479 Opened 6 years ago Closed 6 years ago
Starting a simulator changes host and port settings
Right now, there's only one set of host and port settings in the connection footer. If you start a simulator, the port will likely change to a randomly chosen port at startup time. If you later want to connect to a device, you'll have to edit the port back to 6000 first, then connect. Generally, it feels like we may need to rethink the flow of the connection footer to make it simpler to preserve the device settings.
If you re-use the connection used by the Simulator, indeed. When the simulator closes, we should kill the connection as well, and create a new one.
(not critical for 26)
No longer blocks: appmgr_v1
Comment on attachment 810563 [details] [diff] [review] Patch v1 Needs rebase, connected listener in now a singleton.
The conflicting patch is the one from bug 919681.
Whiteboard: [needed-in-aurora-26] → [waiting for review]
Comment on attachment 811116 [details] [diff] [review] Patch V2 Review of attachment 811116 [details] [diff] [review]: ----------------------------------------------------------------- FYI: If you launch the simulator and immediatly click on cancel, it doesn't reset to 6000. Otherwise, the patch works fine in sane usages of the simulator.
Attachment #811116 - Flags: review?(poirot.alex) → review+
Whiteboard: [waiting for review] → [land-in-fx-team]
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Comment on attachment 811116 [details] [diff] [review] Patch V2 [Approval Request Comment] Bug caused by (feature/regressing bug #): new feature (app manager) User impact if declined: connection params messed up after simulator started Testing completed (on m-c, etc.): m-c Risk to taking this patch (and alternatives if risky): low String or IDL/UUID changes made by this patch: none
Attachment #811116 - Flags: approval-mozilla-aurora?
Attachment #811116 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed with: latest Aurora 27.0a2, latest Nightly 28.0a1 and latest Beta 26 beta 4, on: Win 7 32-bit, Ubuntu 13.04 32-bit, Mac OS X 10.6.8
You need to log in before you can comment on or make changes to this bug.