Closed Bug 917479 Opened 6 years ago Closed 6 years ago

Starting a simulator changes host and port settings

Categories

(DevTools :: WebIDE, defect, P1)

defect

Tracking

(firefox26 verified, firefox27 verified, b2g-v1.2 fixed)

RESOLVED FIXED
Firefox 27
Tracking Status
firefox26 --- verified
firefox27 --- verified
b2g-v1.2 --- fixed

People

(Reporter: jryans, Assigned: paul)

Details

(Keywords: verifyme)

Attachments

(1 file, 1 obsolete file)

Right now, there's only one set of host and port settings in the connection footer.

If you start a simulator, the port will likely change to a randomly chosen port at startup time.  If you later want to connect to a device, you'll have to edit the port back to 6000 first, then connect.

Generally, it feels like we may need to rethink the flow of the connection footer to make it simpler to preserve the device settings.
If you re-use the connection used by the Simulator, indeed.

When the simulator closes, we should kill the connection as well, and create a new one.
(not critical for 26)
No longer blocks: appmgr_v1
Priority: -- → P1
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #810563 - Flags: review?(poirot.alex)
Whiteboard: [needed-in-aurora-26]
Assignee: nobody → paul
Comment on attachment 810563 [details] [diff] [review]
Patch v1

Needs rebase, connected listener in now a singleton.
Attachment #810563 - Flags: review?(poirot.alex)
The conflicting patch is the one from bug 919681.
Attached patch Patch V2Splinter Review
Attachment #810563 - Attachment is obsolete: true
Attachment #811116 - Flags: review?(poirot.alex)
Whiteboard: [needed-in-aurora-26] → [waiting for review]
Comment on attachment 811116 [details] [diff] [review]
Patch V2

Review of attachment 811116 [details] [diff] [review]:
-----------------------------------------------------------------

FYI: If you launch the simulator and immediatly click on cancel, it doesn't reset to 6000.
Otherwise, the patch works fine in sane usages of the simulator.
Attachment #811116 - Flags: review?(poirot.alex) → review+
Keywords: checkin-needed
Whiteboard: [waiting for review] → [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/d079bd51114c
Keywords: checkin-needed
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d079bd51114c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Comment on attachment 811116 [details] [diff] [review]
Patch V2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: connection params messed up after simulator started
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none
Attachment #811116 - Flags: approval-mozilla-aurora?
Whiteboard: [waiting-for-aurora-approval]
Attachment #811116 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Keywords: verifyme
Verified as fixed with: latest Aurora 27.0a2, latest Nightly 28.0a1 and latest Beta 26 beta 4, on: Win 7 32-bit, Ubuntu 13.04 32-bit, Mac OS X 10.6.8
QA Contact: manuela.muntean
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.