919681 - Connecting to Simulator displays duplicate "Connected" messages

Status: VERIFIED FIXED

(DevTools Graveyard :: WebIDE, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:

1. Start Simulator
2. Either it hangs before connecting or you cancel before it connects
3. Try connecting again
4. The message "Connected to simulator." is printed to the log more than once.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Remove duplicate simulator connected handlers

Comment 2

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Comment on attachment 808739 [details] [diff] [review]
Remove duplicate simulator connected handlers

Good catch!

But the patch doesn't work as expected, because of the typical "once" implementation, that registers another internal function instead of the excepted one :(
http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/event-emitter.js?force=1#60

If you want to fix that, I think you have to switch to using "on"...

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 808739 [details] [diff] [review]
Remove duplicate simulator connected handlers

Actually, it should work, because I just fixed exactly the issue you described as part of bug 918588. :D

Did you notice there were still issues even after that?

Comment 4

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Comment on attachment 808739 [details] [diff] [review]
Remove duplicate simulator connected handlers

Ok... I have to say, double good catch \o/

(I was testing against an outdated m-c)

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=c75726f6e4a5

Comment 6

[Paul Rouget [:paul]]

Comment on attachment 808739 [details] [diff] [review]
Remove duplicate simulator connected handlers

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: duplicated string
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): low 
String or IDL/UUID changes made by this patch: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/8739c99b76c2

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8739c99b76c2

Comment 9

[Paul Rouget [:paul]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/673782b4bb7a

Comment 10

[Ioana (away)]

Verified as fixed on Firefox 26b3 - 20131107161719 - on Windows 7 64bit, Ubuntu 13.04 32bit and Mac OS X 10.9.

Comment 11

[Ioana (away)]

Verified as fixed on the 12/04 Aurora on Windows 7 64bit, Ubuntu 13.04 32bit and Mac OS X 10.9.