917608 - JNI wrapper generator moves comment

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mina Almasry]

GeneratedJNIWrappers.h was generated with the comment moved in the patch of bug 890253.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

CC'ing ckitching. I think there should be a comment at the top of the file for sure, but you can also have comments interspersed throughout the file if you like.

Comment 2

[Chris Kitching [:ckitching]]

That's strange. Let's see if this remains a problem after Bug 917512 is done (Which includes some extremely significant changes to the generator).

As long as it's not moving the comment about randomly when you're building causing builds to fail this doesn't seem to be anything more than a style problem (Which of course will be straightforward to fix - but since there's no functional problem I'm reluctant to introduce a race between this and Bug 917512). I assume this is sensible?

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Yeah that's fine.

Comment 4

[Chris Kitching [:ckitching]]

It's good to know I got the right bug number. :P

Comment 5

[Chris Kitching [:ckitching]]

(My above comment is intended to refer to Bug 913985. Bug 917512 is related but not the one I was talking about. Bug 917152 is a typo. Oh what fun.)

Comment 6

[Chris Kitching [:ckitching]]

This got fixed yonks ago...