Closed Bug 917609 Opened 6 years ago Closed 6 years ago

browser_thumbnails_background.js noAlert test should catch window.alert exception

Categories

(Toolkit :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27
Tracking Status
firefox26 --- wontfix
firefox27 --- fixed

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
See bug 915384 comment 7.
Attachment #806345 - Flags: review?(mhammond)
Attachment #806345 - Flags: review?(mhammond) → review+
https://hg.mozilla.org/mozilla-central/rev/ec6019f52f5e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Blocks: 919068
Blocks: 919096
I added 919068 and 919096 as dependencies because those intermittent failures showed up recently, and this bug touched browser_thumbnails_background.js. If there's no possible way your change could have caused these, please break the dependencies.
Flags: needinfo?(adw)
Thanks, I don't think there's any way, but I'll look into them.  There's already another ASAN failure in bug 915384.  This ASAN thing...
No longer blocks: 919068, 919096
Flags: needinfo?(adw)
Comment on attachment 806345 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 915384
User impact if declined: minimal
Testing completed (on m-c, etc.): tryserver with this patch and two, related others I'd like to uplift: https://tbpl.mozilla.org/?tree=Try&rev=c8eda3703066
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Patch applies cleanly to Aurora.
Attachment #806345 - Flags: approval-mozilla-aurora?
Comment on attachment 806345 [details] [diff] [review]
patch

low risk regression fix, will OK for uplift.
Attachment #806345 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 806345 [details] [diff] [review]
patch

Whoops, I meant to cancel these approval requests earlier today.  We're not planning on uplifting this anymore because we're not going to uplift bug 927688 to Aurora/26 after all.

I won't undo the a+, but again, we decided not to uplift this.
Blocks: 931889
You need to log in before you can comment on or make changes to this bug.