917609 - browser_thumbnails_background.js noAlert test should catch window.alert exception

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Drew Willcoxon :adw]

Attachment: patch

See bug 915384 comment 7.

Comment 1

[Drew Willcoxon :adw]

https://hg.mozilla.org/integration/fx-team/rev/ec6019f52f5e

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ec6019f52f5e

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I added 919068 and 919096 as dependencies because those intermittent failures showed up recently, and this bug touched browser_thumbnails_background.js. If there's no possible way your change could have caused these, please break the dependencies.

Comment 4

[Drew Willcoxon :adw]

Thanks, I don't think there's any way, but I'll look into them.  There's already another ASAN failure in bug 915384.  This ASAN thing...

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 806345 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 915384
User impact if declined: minimal
Testing completed (on m-c, etc.): tryserver with this patch and two, related others I'd like to uplift: https://tbpl.mozilla.org/?tree=Try&rev=c8eda3703066
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Patch applies cleanly to Aurora.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 806345 [details] [diff] [review]
patch

low risk regression fix, will OK for uplift.

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 806345 [details] [diff] [review]
patch

Whoops, I meant to cancel these approval requests earlier today.  We're not planning on uplifting this anymore because we're not going to uplift bug 927688 to Aurora/26 after all.

I won't undo the a+, but again, we decided not to uplift this.