917770 - User pinned sites are removed if the bookmark is removed

Status: RESOLVED DUPLICATE of bug 856565

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Adrian Tamas (:AdrianT)]

Aurora 26.0a1 2013-09-18
Samsung Galaxy Tab 2 (Android 4.1.1)

Steps to reproduce:
1) Bookmark a website.
2) Pin the bookmark in the Top Bookmarks section
3) Remove the bookmark either from the context menu or from the menu

Expected results:
The bookmark is removed but since the user explicitly pinned the website the pinned website is not removed

Actual results:
The pinned site is removed

Comment 1

[Aaron Train [:aaronmt]]

Invalid provided the upcoming changes, Lucas?

Comment 2

[Lucas Rocha (:lucasr)]

Yep, going away once the changes land.

Comment 3

[:Margaret Leibovic]

I think things here have even changed since bug 917455 landed... lucasr, can we just close this?

Comment 4

[Lucas Rocha (:lucasr)]

I haven't look at the code but this looks like a bug in the way we implemented the 'remove' action in the bookmarks panel? The 'remove' action should only remove the specific bookmark entry instead of removing all bookmarks matching that url (because pinned sites are stored as bookmarks).

Comment 5

[:Margaret Leibovic]

Chenxia, can you look into this?

Comment 6

[Chenxia Liu [:liuche]]

I started to try to fix this, but realized that I can't actually repro it - this is actually a dupe of bug 856565, which has been fixed for a while.

Comment 7

[:Margaret Leibovic]

(In reply to Chenxia Liu [:liuche] from comment #6)
> I started to try to fix this, but realized that I can't actually repro it -
> this is actually a dupe of bug 856565, which has been fixed for a while.
> 
> *** This bug has been marked as a duplicate of bug 856565 ***

Excellent :) Thanks for investigating!