917824 - [Contacts] Use Full Line Highlights

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Eric Pang [:epang] UX]

Attachment: Contacts - Margin for Index.jpg

Highlight extends to the edge on the left.  On the right there is a 30px margin to allow for the scroll index.

Comment 1

[Eric Pang [:epang] UX]

Flagging as 1.3? since the highlight state currently looks broken.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

triage: would not block release but please land it when its ready

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Pavel, I could work in the missing Highlight bugs, if you don't mind.

Comment 4

[Eric Pang [:epang] UX]

(In reply to Arnau March from comment #3)
> Pavel, I could work in the missing Highlight bugs, if you don't mind.

This would be great Arnau!  Pavel is really busy with the 1.3 refresh bugs.  Thanks! :)

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 6

[Eric Pang [:epang] UX]

Comment on attachment 8340959 [details]
patch in github

Looks good, thanks Arnau!

Comment 7

[Jose Manuel Cantera]

Comment on attachment 8340959 [details]
patch in github

thanks Arnau

Comment 8

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/c6a9570f7d69078f28bf0bd3bee336ca2470d08c

Comment 9

[Kevin Grandon :kgrandon]

The patch in this bug removes the overflow hidden attribute from contacts.css and trigger reopening of bug 937291. If this is the case we may need to back this out. (This patch also leaves an empty CSS selector in the stylesheet.

I haven't had the time to look into this yet, but I am currently profiling some code so I may give this a quick test.

Also NI? on Ben so he is aware.

Comment 10

[Jose Manuel Cantera]

(In reply to Kevin Grandon :kgrandon from comment #9)
> The patch in this bug removes the overflow hidden attribute from
> contacts.css and trigger reopening of bug 937291. If this is the case we may
> need to back this out. (This patch also leaves an empty CSS selector in the
> stylesheet.
> 

Oh that would be unfortunate. Instead of backing out it could be better to fix it asap. Backing out will imply that we will having visual regressions in contacts. Ni Arnau to look into that and fix asap. 

> I haven't had the time to look into this yet, but I am currently profiling
> some code so I may give this a quick test.
> 
> Also NI? on Ben so he is aware.

Comment 11

[Ben Kelly [:bkelly, not reviewing]]

Thanks Jose!  To be clear, we mainly need the overflow: hidden attribute added back to the .group-section class.

It would be great if we could add a comment there as well since this is the second time the attribute has been removed in a PR.  Sorry for not putting one there originally!

Comment 12

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

I'll work on this right now. Sorry about that, just removed the overflow hidden to be able to show the pressed stated. I will add the comment on the code. This kind of tricks are impossible to know to someone how is out of the loop.