947819 - [Contacts] add overflow: hidden to contacts list

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Overflow: hidden property was removed in: https://bugzilla.mozilla.org/show_bug.cgi?id=917824

As commented in https://bugzilla.mozilla.org/show_bug.cgi?id=937291 this will improve reflow.

Comment 1

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Ben, do you want to review this as today is bank holiday for Jose Manuel?

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8344514 [details]
patch in github

Arnau, this looks good to me, but I can't verify it on my device at the moment because I have a 1.2 load for a koi+ bug.  So I'm only giving it f+ for now.

If I get a chance to load 1.3 on my phone to test I will r+, but I'm also ok waiting for Jose Manuel to review tomorrow.  The tree is closed at the moment, anyway, so we will have to wait to land it regardless.

Thanks again!

Comment 4

[Jose Manuel Cantera]

Comment on attachment 8344514 [details]
patch in github

thanks Arnau

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

I went ahead and landed this to make it in before 1.3 branch:

  https://github.com/mozilla-b2g/gaia/commit/1010882db80b7c9cea54773778842c176d318423

Thanks!