917837 - [Music] Use Full Line Highlights in Album View

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Eric Pang [:epang] UX]

Attachment: Music-Album-View.png

In the selected album view use full width highlights (edge to edge) for active/pressed states.

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: shot

Hey Eric, 
this is the current master and the active/pressed state is from edge to edge. Do I need to do something here?

Comment 2

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #1)
> Created attachment 808286 [details]
> shot
> 
> Hey Eric, 
> this is the current master and the active/pressed state is from edge to
> edge. Do I need to do something here?

Hi Pavel, didn't realize they were at full length.  Can we update the color and opacity of the highlight? the same highlight colour should be used throughout the music app.
#348c9e
60% Opacity

Comment 3

[Eric Pang [:epang] UX]

(In reply to Eric Pang [:epang] from comment #2)
> (In reply to Pavel Ivanov [:ivanovpavel] from comment #1)
> > Created attachment 808286 [details]
> > shot
> > 
> > Hey Eric, 
> > this is the current master and the active/pressed state is from edge to
> > edge. Do I need to do something here?
> 
> Hi Pavel, didn't realize they were at full length.  Can we update the color
> and opacity of the highlight? the same highlight colour should be used
> throughout the music app.
> #348c9e
> 60% Opacity

Hey Pavel, has this been updated?  If so, I'll test out the patch.  Just let me know :).
Thanks!

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch screenshot (desktop)

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 6

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #4)
> Created attachment 817152 [details]
> After patch screenshot (desktop)

Hey Pavel, did you mean to post the screen to this bug 917840?  That bug is for the view that doesn't have album art on the right side (second level, after selecting a artist, playlist, or album).  

I've tested for this screen and it looks good now (but I'll need you to update the screen).  For the screen you attached that I think is for 817152 it's almost there, but the highlight shouldn't be visible from the right side of the album art (where the index scroll should be - it's currently missing but there's a bug open to fix it).  Thanks!

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Ohh sure ... sorry I attached the wrong shot ... but the highlight color is the same ... anyway :) I will update the screen today and ping you back for info :) Thanks

Comment 8

[Eric Pang [:epang] UX]

Flagging as 1.3? since the highlight state currently looks broken.

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch screenshot

The space from the right side will be fixed when we have the Alphabetical list there

Comment 10

[Eric Pang [:epang] UX]

Comment on attachment 818226 [details]
After patch screenshot

I don't think the search index is used in screens at this level so this should be fine :). Thanks!

Comment 11

[Jim Porter (:squib)]

Comment on attachment 817153 [details]
patch for Gaia/master

Another simple CSS patch. rs=me.

Comment 12

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks Jim :)

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/4fda96766497080e39db01824f4c9c6c754e4627

Comment 13

[Jason Smith [:jsmith]]

Already in 1.3, removing blocking flag