Move tests in browser/base/content/tests to browser/base/content/tests/general

RESOLVED FIXED in Firefox 27

Status

()

RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

Trunk
Firefox 27
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Moving the tests in browser/base/content/tests to browser/base/content/tests/general will shorten the amount of time needed to just run the "general" tests. Currently when running `mach mochitest-browser browser/base/content/test` the social and newtab tests run as well, which adds a considerable amount of time to the local test run.

The newtab and social test directories will remain as direct children of browser/base/content/test.

After this bug is fixed, the directory structure should look like:
/browser/base/content/test
/browser/base/content/test/general/
/browser/base/content/test/newtab/
/browser/base/content/test/social/

If there is any potential to move groups of test that focus on specific functionality then those can move to their own specific folder.
Created attachment 806771 [details] [diff] [review]
Patch

Notable changes in this patch:
1) There were many references to file paths within tests. These needed to have 'general/' inserted within the path.
2) There were 3 references to 'social/moz.png', a file that doesn't exist. The file, moz.png, actually existed in the social directory's parent directory. I fixed these references to point to 'general/moz.png'.

I confirmed locally that running `mach mochitest-browser browser/base/content/test` still runs all of the tests, and running `mach mochitest-browser browser/base/content/test/general` runs only the tests in the 'general' directory.

https://tbpl.mozilla.org/?tree=Try&rev=624288f6ce19
Attachment #806771 - Flags: review?(gavin.sharp)
Created attachment 806808 [details] [diff] [review]
Patch v1.1

Fixed references outside of browser/base/content and repushed to tryserver:
https://tbpl.mozilla.org/?tree=Try&rev=fb289fd2dd43
Attachment #806771 - Attachment is obsolete: true
Attachment #806771 - Flags: review?(gavin.sharp)
Attachment #806808 - Flags: review?(gavin.sharp)
Comment on attachment 806808 [details] [diff] [review]
Patch v1.1

rs=me
Attachment #806808 - Flags: review?(gavin.sharp) → review+

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d558e1102e02
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Blocks: 919698
No longer blocks: 919698
Depends on: 919698

Updated

3 years ago
See Also: → bug 1265052
You need to log in before you can comment on or make changes to this bug.