Closed Bug 917887 Opened 7 years ago Closed 7 years ago

Move tests in browser/base/content/tests to browser/base/content/tests/general


(Firefox :: General, defect)

Not set



Firefox 27


(Reporter: jaws, Assigned: jaws)




(1 file, 1 obsolete file)

Moving the tests in browser/base/content/tests to browser/base/content/tests/general will shorten the amount of time needed to just run the "general" tests. Currently when running `mach mochitest-browser browser/base/content/test` the social and newtab tests run as well, which adds a considerable amount of time to the local test run.

The newtab and social test directories will remain as direct children of browser/base/content/test.

After this bug is fixed, the directory structure should look like:

If there is any potential to move groups of test that focus on specific functionality then those can move to their own specific folder.
Attached patch Patch (obsolete) — Splinter Review
Notable changes in this patch:
1) There were many references to file paths within tests. These needed to have 'general/' inserted within the path.
2) There were 3 references to 'social/moz.png', a file that doesn't exist. The file, moz.png, actually existed in the social directory's parent directory. I fixed these references to point to 'general/moz.png'.

I confirmed locally that running `mach mochitest-browser browser/base/content/test` still runs all of the tests, and running `mach mochitest-browser browser/base/content/test/general` runs only the tests in the 'general' directory.
Attachment #806771 - Flags: review?(
Attached patch Patch v1.1Splinter Review
Fixed references outside of browser/base/content and repushed to tryserver:
Attachment #806771 - Attachment is obsolete: true
Attachment #806771 - Flags: review?(
Attachment #806808 - Flags: review?(
Comment on attachment 806808 [details] [diff] [review]
Patch v1.1

Attachment #806808 - Flags: review?( → review+
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Blocks: 919698
No longer blocks: 919698
Depends on: 919698
See Also: → 1265052
You need to log in before you can comment on or make changes to this bug.