917944 - Remove "Most recent" header in history page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[:Margaret Leibovic]

Now that we don't have "Most visited", the "Most recent" header doesn't feel necessary.

But we should keep the "Tabs from last time" header when that page has content.

Comment 1

[Lucas Rocha (:lucasr)]

(In reply to :Margaret Leibovic from comment #0)
> Now that we don't have "Most visited", the "Most recent" header doesn't feel
> necessary.
> 
> But we should keep the "Tabs from last time" header when that page has
> content.

That will make the tab switch feel a bit clunky, no? i.e. one tab with a title and the other without.

Comment 2

[Ian Barlow (:ibarlow)]

Maybe, maybe not. In our earlier History Panel, we had different lists for Most Frequent and Most Recent (this one had an extra header for date) and I never really noticed that...

Comment 3

[Mark Capella [:capella]]

Attachment: bug917944 (v0)

Comment 4

[Mark Capella [:capella]]

This leaves the title field in the home_history_list.xml but doesn't populate it for the home_most_recent_page fragment ...

Comment 5

[:Margaret Leibovic]

Comment on attachment 808291 [details] [diff] [review]
bug917944 (v0)

Review of attachment 808291 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Note to self: we don't need to remove the string because it is also used to add the tab for this page in HistoryPage.java.

Comment 6

[:Margaret Leibovic]

This is a small polish issue we'll probably want to uplift to 26 with the new-new-about-home changes.

Comment 7

[Mark Capella [:capella]]

Quick run through try: https://tbpl.mozilla.org/?tree=Try&rev=2959c1d24c34

Comment 8

[Mark Capella [:capella]]

And on we go ... I accept chocolate bit-coins
https://hg.mozilla.org/integration/fx-team/rev/403743a219a3

Comment 9

[Ed Morley [:emorley]]

Backed out for robocop-2 failures on Android 2.2:
https://tbpl.mozilla.org/php/getParsedLog.php?id=28272377&tree=Fx-Team

https://hg.mozilla.org/integration/fx-team/rev/36d351d8269b

Comment 10

[Mark Capella [:capella]]

mmm ... I passed a try push ... testShareLink mid-air collision?

Comment 11

[Mark Capella [:capella]]

Attachment: bug917944 (v1)

Switching the waitForText() value from the "Most recent" literal to "Today" works out just fine ...

https://tbpl.mozilla.org/?tree=Try&rev=94df3d872089

Comment 12

[:Margaret Leibovic]

Comment on attachment 809760 [details] [diff] [review]
bug917944 (v1)

Review of attachment 809760 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/tests/StringHelper.java.in
@@ +92,5 @@
>      public static final String HISTORY_LABEL = "HISTORY";
>      public static final String TOP_SITES_LABEL = "TOP SITES";
>      public static final String BOOKMARKS_LABEL = "BOOKMARKS";
>      public static final String READING_LIST_LABEL = "READING LIST";
> +    public static final String MOST_RECENT_LABEL = "Today";

I would prefer to see you rename this variable TODAY_LABEL, then update where it's used, adding a comment explaining this assumption that pages must be visited during the test run for this check to pass.

Comment 13

[Mark Capella [:capella]]

Attachment: bug917944 (v2)

Nice touches.

Comment 14

[:Margaret Leibovic]

Comment on attachment 810124 [details] [diff] [review]
bug917944 (v2)

Thanks.

Comment 15

[Mark Capella [:capella]]

TRY https://tbpl.mozilla.org/?tree=Try&rev=eda931926e93
FX-TEAM https://hg.mozilla.org/integration/fx-team/rev/1c5e6b8ebbde

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1c5e6b8ebbde

Comment 17

[Lucas Rocha (:lucasr)]

Capella, request uplift to Aurora?

Comment 18

[Mark Capella [:capella]]

Comment on attachment 810124 [details] [diff] [review]
bug917944 (v2)

[Approval Request Comment] This has been in m-c for about three weeks, fairly easy bug ... not sure who q/a'd it ... looks like resolved "fixed" by Tomcat

Bug caused by (feature/regressing bug #): Initial About:home implementation
User impact if declined: They can wait a little longer for it to get prettier.
Testing completed (on m-c, etc.): local to me, m-c/nightly by me
Risk to taking this patch (and alternatives if risky): It might interrupt someones work flow? meh - none - we can put if back if we have to.
String or IDL/UUID changes made by this patch: None

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/89458280a982

Comment 20

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 26.0a2 (2013-10-28) and Firefox for Android 27.0a1 (2013-10-28)
Device: Samsung Galaxy Nexus
OS: Android 4.1.1