917966 - Lightning 2.6 release packages advertise wrong version number

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

When I manually changed the version in install.rdf, I forgot to do so in application.ini and the useragent pref.

> $ grep -r 2.6b3 *
> application.ini:Version=2.6b3
> defaults/preferences/lightning.js:pref("calendar.useragent.extra", 

This needs fixing for 2.6.1

Comment 1

[Stefan Sitter [:ssitter]]

Could you please bump the version number on comm-esr24 to ensure that 2.6.* test builds are not updated 'back' to 2.6 by Thunderbird?

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Ah the builds have already started on Thunderbird infra, didn't think to check the version number in the repo, I though this would be more of an issue of me making sure that if I need to change the version number for any reason, I do so in all locations.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

I've changed my script to accommodate the remaining files. No more traces of 2.6b3.

oskar:release kewisch$ changeversion.sh lightning-win32.xpi 2.6.1
Changing 2.6b3 to 2.6.1
	install.rdf
	application.ini
	defaults/preferences/lightning.js
Saved to lightning-win32.xpi
oskar:release kewisch$ mkdir ttt
oskar:release kewisch$ cd ttt
oskar:ttt kewisch$ unzip -q ../lightning-mac.xpi 
oskar:ttt kewisch$ grep -r 2.6b3 *
oskar:ttt kewisch$

Comment 4

[Stefan Sitter [:ssitter]]

Nevertheless please update comm-esr24 to ensure that users who pull the source or download the source code tarball will get the proper version and build.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

I've done so for the next possible release in https://hg.mozilla.org/releases/comm-esr24/rev/059874c5f58b

Mark, would it be ok to also change the version on the relbranch for 24.0.1 and retag _BUILD1 and _RELEASE?