918003 - Defect - Profile data should flush for suspend_process_notification

Status: RESOLVED WORKSFORME

(Firefox for Metro Graveyard :: General, defect)

Description

[Brian R. Bondy [:bbondy]]

Windows 8 and 8.1 can suspend your application and kill it without notification. For that reason we should be flushing important data just before suspending. 

I haven't tested this, but I think we'll miss out on some bookmarks, login information, or other data if we don't flush on suspend. 

To verify this works (or verify it doesn't work pre a patch) you'd:
1) switch away from browser, wait 20 seconds so you're sure the browser is suspended.
2) kill the browser via task manager
3) Re-open the browser

Comment 1

[Brian R. Bondy [:bbondy]]

[ 15:12:27 ] [ @TimAbraldes ] the patch might look kind of like this :) https://bugzilla.mozilla.org/attachment.cgi?id=746085&action=diff

Comment 2

[Marina Samuel [:emtwo]]

Do you know if there is an existing function that flushes data when the browser is killed that we just want to use when it is suspended? Or does any flushing functionality not exist yet?

Comment 3

[Brian R. Bondy [:bbondy]]

We should first test what comment 0 is proposing. I'm not sure if it's a problem or not.  But if you confirm, then we should do like in Comment 1 by listening for a notification and then responding to it in the component that is not working. We should find out which components first to avoid looking up code we won't need to do this on.

Comment 4

[Jim Mathies [:jimm]]

Note, we also have bug 917997 on sync. Bug 855147 covered prefs, which is fixed. 

I think what we want to sync here is certain types of profile data. bookmarks is the one I can think of. Are there others? Open question is can we sync everything with one call, or are going to have to sync different datasets individually.

We could use some help from someone who understands profiles.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

What "data" are we talking about here? If it's just the preferences data, we can force a flush using PrefService.savePrefFile(null)

http://mxr.mozilla.org/mozilla-central/source/modules/libpref/public/nsIPrefService.idl#76

Comment 6

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

We dealt with prefs in bug 855147. I think this bug is about bookmarks, password manager, and maybe other types of data.

Comment 7

[Allison Naaktgeboren :ally]

couldn't repro with bookmarks, forms, or history.