Closed
Bug 918321
Opened 11 years ago
Closed 11 years ago
Remove some dead code from the JS engine
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: ehsan.akhgari, Assigned: sfink)
References
Details
Attachments
(2 files)
18.41 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
2.81 KB,
patch
|
Details | Diff | Splinter Review |
Discovered by clang.
Attachment #807190 -
Flags: review?(luke)
Comment 1•11 years ago
|
||
Comment on attachment 807190 [details] [diff] [review] Patch (v1) Thanks!
Attachment #807190 -
Flags: review?(luke) → review+
Reporter | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/04bf94160337
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 807190 [details] [diff] [review] Patch (v1) Review of attachment 807190 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jit/MIR.h @@ +8454,5 @@ > > class MAsmJSLoadGlobalVar : public MNullaryInstruction > { > MAsmJSLoadGlobalVar(MIRType type, unsigned globalDataOffset, bool isConstant) > + : globalDataOffset_(globalDataOffset) Seems like the isConstant parameter is dead now too.
Assignee | ||
Comment 4•11 years ago
|
||
Or would this be useful information in the future?
Attachment #807327 -
Flags: review?(luke)
Assignee | ||
Updated•11 years ago
|
Assignee: ehsan → sphink
Comment 5•11 years ago
|
||
Let's check with Douglas: are there some pending patches that will be using isConstant?
Flags: needinfo?(dtc-moz)
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/04bf94160337
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Comment 7•11 years ago
|
||
The lack of use of isConstant might be a regression from bug 877338, or it might no longer be necessary after the patch in 877338. It might still be possible to relax the constraints on movement of a global load when it is a constant. I'll need to study the code further.
Updated•11 years ago
|
Flags: needinfo?(dtc-moz)
Updated•11 years ago
|
Attachment #807327 -
Flags: review?(luke)
You need to log in
before you can comment on or make changes to this bug.
Description
•