Closed Bug 920452 Opened 6 years ago Closed 6 years ago

Odinmonkey: constant global variables have no alias dependencies

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: dougc, Assigned: dougc)

References

Details

Attachments

(1 file, 1 obsolete file)

Some dead code was noted in bug 918321, which appears to be
a small rebasing regression introduced in bug 877338.

Asm.js global const variables have no alias dependencies
and can even be hoisted above a call.  They are initialized
when the closure is created and can not be modified.
Attachment #809802 - Flags: review?(bbouvier)
Comment on attachment 809802 [details] [diff] [review]
Constant global variables have no alias dependencies

Review of attachment 809802 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!

::: js/src/jit/MIR.h
@@ +8625,5 @@
>  
>  class MAsmJSLoadGlobalVar : public MNullaryInstruction
>  {
>      MAsmJSLoadGlobalVar(MIRType type, unsigned globalDataOffset, bool isConstant)
> +        : globalDataOffset_(globalDataOffset), isConstant_(isConstant)

nit: 2 spaces before ':'
Attachment #809802 - Flags: review?(bbouvier) → review+
Fix white space.  Carrying forward r+.
Attachment #809802 - Attachment is obsolete: true
Attachment #810284 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5a2bfaac8236
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.