Closed
Bug 920452
Opened 12 years ago
Closed 12 years ago
Odinmonkey: constant global variables have no alias dependencies
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: dougc, Assigned: dougc)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.68 KB,
patch
|
dougc
:
review+
|
Details | Diff | Splinter Review |
Some dead code was noted in bug 918321, which appears to be
a small rebasing regression introduced in bug 877338.
Asm.js global const variables have no alias dependencies
and can even be hoisted above a call. They are initialized
when the closure is created and can not be modified.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #809802 -
Flags: review?(bbouvier)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 809802 [details] [diff] [review]
Constant global variables have no alias dependencies
Review of attachment 809802 [details] [diff] [review]:
-----------------------------------------------------------------
Nice catch!
::: js/src/jit/MIR.h
@@ +8625,5 @@
>
> class MAsmJSLoadGlobalVar : public MNullaryInstruction
> {
> MAsmJSLoadGlobalVar(MIRType type, unsigned globalDataOffset, bool isConstant)
> + : globalDataOffset_(globalDataOffset), isConstant_(isConstant)
nit: 2 spaces before ':'
Attachment #809802 -
Flags: review?(bbouvier) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Fix white space. Carrying forward r+.
Attachment #809802 -
Attachment is obsolete: true
Attachment #810284 -
Flags: review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 4•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•