918535 - Defect - Dismissing the soft keyboard in the start screen requires two taps.

Status: RESOLVED FIXED

(Core Graveyard :: Widget: WinRT, defect, P2)

Description

[Marina Samuel [:emtwo]]

STR:
1) Tap the URL bar => keyboard slides in
2) Tap anywhere on the start screen

Expected results: Keyboard slides back in

Actual results: URL bar slides in on first tap and keyboard on second tap

Comment 1

[juan becerra [:juanb]]

See also bug 920175

Comment 2

[Jim Mathies [:jimm]]

Hmm, I'm having trouble reproducing this.

Comment 3

[Rodrigo Silveira [:rsilveira] [:rodms]]

I can reproduce with a build from yesterday evening, will take a look.

Comment 4

[Rodrigo Silveira [:rsilveira] [:rodms]]

On the first click the urlbar blurs as expected. The focus goes to #main-window but the keyboard is still up. I tried moving the focus to other elements but the keyboard is still there. It's as if the accessibility layer didn't catch that we changed focus.

Comment 5

[Marco Mucci [:MarcoM]]

Hey Rodrigo, will you be taking this Defect during IT#16?  If so, can you provide a point value.

Comment 6

[Jim Mathies [:jimm]]

Mind if I take this? I'm pretty sure this is down in the UIABridge code of widget.

Comment 7

[Jim Mathies [:jimm]]

Attachment: fix

With this applied in widget the problem should be addressed.

Comment 8

[Marco Mucci [:MarcoM]]

Thanks Jim.  I'll add it.

Comment 9

[Rodrigo Silveira [:rsilveira] [:rodms]]

Comment on attachment 812037 [details] [diff] [review]
fix

Review of attachment 812037 [details] [diff] [review]:
-----------------------------------------------------------------

I tried the patch and the issue is fixed. The code looks like is doing a relevant thing :), but I'm not familiar with the widget code to r+ it.

Comment 10

[Rodrigo Silveira [:rsilveira] [:rodms]]

(In reply to Jim Mathies [:jimm] from comment #6)
> Mind if I take this? I'm pretty sure this is down in the UIABridge code of
> widget.

Thanks for taking it by the way :)

Comment 11

[Jim Mathies [:jimm]]

Comment on attachment 812037 [details] [diff] [review]
fix

r? -> bbondy

Comment 12

[Jim Mathies [:jimm]]

(In reply to Rodrigo Silveira [:rsilveira] from comment #10)
> (In reply to Jim Mathies [:jimm] from comment #6)
> > Mind if I take this? I'm pretty sure this is down in the UIABridge code of
> > widget.
> 
> Thanks for taking it by the way :)

np :) been meaning to get to it. sorry you had to spend front end time on it.

Comment 13

[Brian R. Bondy [:bbondy]]

Comment on attachment 812037 [details] [diff] [review]
fix

Review of attachment 812037 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/winrt/UIABridge.cpp
@@ +177,5 @@
> +    return UIA_E_ELEMENTNOTAVAILABLE;
> +  }
> +
> +  nsCOMPtr<nsIAccessible> child;
> +  nsresult rv = mAccessible->GetFocusedChild(getter_AddRefs(child));

nit: unreferenced local variable rv

Comment 14

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/fx-team/rev/533241317d0f

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/533241317d0f

Comment 16

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #16 without issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-16-03-02-02-mozilla-central/

- Went through the original issue described in comment #0 without any issues
- Ensured that the OSK is dismissed while the Navigation App Bar slides to the bottom using a single tap (start screen)
- Ensured that the OSK is dismissed while vieiwng websites using a single tap
- Went through all of the above test cases using full, filled & snapped views without issues