Closed
Bug 918588
Opened 11 years ago
Closed 11 years ago
Event Emitter: Can't call off after once
Categories
(DevTools :: Framework, defect, P1)
DevTools
Framework
Tracking
(firefox26 fixed, firefox27 fixed)
RESOLVED
FIXED
Firefox 27
People
(Reporter: jryans, Assigned: jryans)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
2.45 KB,
patch
|
paul
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The once method stores a wrapped handler, so it's not possible to pass something into off that will remove a single handler.
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Updated•11 years ago
|
Attachment #807530 -
Flags: review?(mratcliffe) → review+
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/42d54d6f6d1c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
|
|
||
Updated•11 years ago
|
Whiteboard: [needed-in-aurora-26]
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 807530 [details] [diff] [review] Properly support off after once with EventEmitter [Approval Request Comment] Bug caused by (feature/regressing bug #): new feature (app manager) User impact if declined: wrong info in the app manager (see bug 919681) Testing completed (on m-c, etc.): m-c Risk to taking this patch (and alternatives if risky): low String or IDL/UUID changes made by this patch: none
Attachment #807530 -
Flags: approval-mozilla-aurora?
|
|
||
Updated•11 years ago
|
Priority: -- → P1
|
||
Updated•11 years ago
|
Attachment #807530 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•