Closed Bug 918645 Opened 9 years ago Closed 9 years ago

crash in java.lang.SecurityException: WifiService: Neither user 10061 nor current process has android.permission.ACCESS_WIFI_STATE. at android.os.Parcel.readException(Parcel.java)

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
critical

Tracking

(firefox25+ fixed, firefox26 fixed, firefox27 fixed)

VERIFIED FIXED
Firefox 27
Tracking Status
firefox25 + fixed
firefox26 --- fixed
firefox27 --- fixed

People

(Reporter: kbrosnan, Assigned: blassey)

References

Details

(Keywords: crash, reproducible, topcrash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-e78d512a-4f44-4cc0-839a-713752130920.
=============================================================

We likely need to take a similar fix to the LG Optimus Black crash on the SMS web API.
Crash happens when Firefox is open and connecting to a WiFi network.

STR:
* Open Firefox Beta
* Open the Android WiFi settings
* Connect to a network
* Switch back to Firefox Beta
* Crash dialog appears
from the stack it looks like we're failing on a call to WifiManager.getDhcpInfo(), which requires no permissions and has been around since API level 1 (though deprecated in API level 18)

http://developer.android.com/reference/android/net/wifi/WifiManager.html#getDhcpInfo%28%29
We'll temporarily block the LG Optimus Black for this bug, although upon further review we may deem these STR non-critical.
Reproducing it on LG Optimus 4x (ARMv7 - Paul Feher) and LG Optimus Slider (ARMv6)
(In reply to Alex Keybl [:akeybl] from comment #4)
> We'll temporarily block the LG Optimus Black for this bug, although upon
> further review we may deem these STR non-critical.

We've been able to reproduce on multiple LG devices at this point - taking a look at the Play Store that would mean blocking 292 devices. Let's only take that drastic action if we start hearing complaints in reviews. We can get a fix into b2, once found.
Seeing plenty of mixed devices in the reports, not just LG.
so.. the problem here is bug 888268 landed in 25 that requires the WiFi permissions that were already requested for bug 866957.
I haven't built or tested this patch
Attachment #807829 - Flags: review?(mcmanus)
Comment on attachment 807829 [details] [diff] [review]
getDhcpInfo.patch

thanks brad
Attachment #807829 - Flags: review?(mcmanus) → review+
Crash Signature: [@ java.lang.SecurityException: WifiService: Neither user 10061 nor current process has android.permission.ACCESS_WIFI_STATE. at android.os.Parcel.readException(Parcel.java)] → [@ java.lang.SecurityException: WifiService: Neither user 10061 nor current process has android.permission.ACCESS_WIFI_STATE. at android.os.Parcel.readException(Parcel.java)] [java.lang.SecurityException: WifiService: Neither user 10101 nor current proce…
Current thinking is to get this landed for Monday, and fast turn around push out Monday or Tuesday. Will of course require verification.
Assignee: nobody → blassey.bugs
Keywords: verifyme
Crash Signature: [@ java.lang.SecurityException: WifiService: Neither user 10061 nor current process has android.permission.ACCESS_WIFI_STATE. at android.os.Parcel.readException(Parcel.java)] [java.lang.SecurityException: WifiService: Neither user 10101 nor current proce… → [@ java.lang.SecurityException: WifiService: Neither user 10061 nor current process has android.permission.ACCESS_WIFI_STATE. at android.os.Parcel.readException(Parcel.java)] [@ java.lang.SecurityException: WifiService: Neither user 10101 nor current pro…
Reproducible on my LG Nexus 4 (Android 4.3). Safe to say reproducible everywhere.

↳ Launch browser → disable Wi-Fi → enable Wi-Fi  → return to browser → crash

Using the attached patch in Brad's custom build fixes this for me
Keywords: reproducible
https://hg.mozilla.org/mozilla-central/rev/b0ec597b7453
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Status: RESOLVED → VERIFIED
Keywords: verifyme
Comment on attachment 807829 [details] [diff] [review]
getDhcpInfo.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 918378
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or IDL/UUID changes made by this patch:
Attachment #807829 - Flags: approval-mozilla-beta?
Attachment #807829 - Flags: approval-mozilla-aurora?
This is single-handedly pushing the crash rate for 25.0b1 on Android to 13 crashes per 100 ADI
Keywords: topcrash
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #16)
> This is single-handedly pushing the crash rate for 25.0b1 on Android to 13
> crashes per 100 ADI

It's a beta product, and we're planning on releasing b2 tomorrow morning. We'll make sure to communicate it as fixed in the next update.
Attachment #807829 - Flags: approval-mozilla-beta?
Attachment #807829 - Flags: approval-mozilla-beta+
Attachment #807829 - Flags: approval-mozilla-aurora?
Attachment #807829 - Flags: approval-mozilla-aurora+
See Also: → 1088952
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.