918645 - crash in java.lang.SecurityException: WifiService: Neither user 10061 nor current process has android.permission.ACCESS_WIFI_STATE. at android.os.Parcel.readException(Parcel.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

This bug was filed from the Socorro interface and is 
report bp-e78d512a-4f44-4cc0-839a-713752130920.
=============================================================

We likely need to take a similar fix to the LG Optimus Black crash on the SMS web API.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Seems similar to https://bugzilla.mozilla.org/show_bug.cgi?id=856445#c35

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Crash happens when Firefox is open and connecting to a WiFi network.

STR:
* Open Firefox Beta
* Open the Android WiFi settings
* Connect to a network
* Switch back to Firefox Beta
* Crash dialog appears

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

from the stack it looks like we're failing on a call to WifiManager.getDhcpInfo(), which requires no permissions and has been around since API level 1 (though deprecated in API level 18)

http://developer.android.com/reference/android/net/wifi/WifiManager.html#getDhcpInfo%28%29

Comment 4

[Alex Keybl [:akeybl]]

We'll temporarily block the LG Optimus Black for this bug, although upon further review we may deem these STR non-critical.

Comment 5

[Ioana Chiorean]

Reproducing it on LG Optimus 4x (ARMv7 - Paul Feher) and LG Optimus Slider (ARMv6)

Comment 6

[Alex Keybl [:akeybl]]

(In reply to Alex Keybl [:akeybl] from comment #4)
> We'll temporarily block the LG Optimus Black for this bug, although upon
> further review we may deem these STR non-critical.

We've been able to reproduce on multiple LG devices at this point - taking a look at the Play Store that would mean blocking 292 devices. Let's only take that drastic action if we start hearing complaints in reviews. We can get a fix into b2, once found.

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

So this is device independent and looks rather bad atm https://crash-stats.mozilla.com/query/?product=FennecAndroid&version=FennecAndroid%3A25.0b1&range_value=1&range_unit=weeks&query_search=signature&query_type=contains&query=&reason=&release_channels=&build_id=&process_type=any&hang_type=any

Comment 8

[Aaron Train [:aaronmt]]

Seeing plenty of mixed devices in the reports, not just LG.

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

so.. the problem here is bug 888268 landed in 25 that requires the WiFi permissions that were already requested for bug 866957.

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: getDhcpInfo.patch

I haven't built or tested this patch

Comment 11

[Patrick McManus [:mcmanus]]

Comment on attachment 807829 [details] [diff] [review]
getDhcpInfo.patch

thanks brad

Comment 12

[Alex Keybl [:akeybl]]

Current thinking is to get this landed for Monday, and fast turn around push out Monday or Tuesday. Will of course require verification.

Comment 13

[Aaron Train [:aaronmt]]

Reproducible on my LG Nexus 4 (Android 4.3). Safe to say reproducible everywhere.

↳ Launch browser → disable Wi-Fi → enable Wi-Fi  → return to browser → crash

Using the attached patch in Brad's custom build fixes this for me

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b0ec597b7453

Comment 15

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 807829 [details] [diff] [review]
getDhcpInfo.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 918378
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or IDL/UUID changes made by this patch:

Comment 16

[Robert Kaiser]

This is single-handedly pushing the crash rate for 25.0b1 on Android to 13 crashes per 100 ADI

Comment 17

[Alex Keybl [:akeybl]]

(In reply to Robert Kaiser (:[e-mail]) from comment #16)
> This is single-handedly pushing the crash rate for 25.0b1 on Android to 13
> crashes per 100 ADI

It's a beta product, and we're planning on releasing b2 tomorrow morning. We'll make sure to communicate it as fixed in the next update.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e9e0d1bf1425
https://hg.mozilla.org/releases/mozilla-beta/rev/eda4dbed18fe