918786 - Contacts App allows empty email addresses

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

We need to check whether an email address is empty (blank spaces) and in the case not to create any entry in contact.email.

Comment 1

[Salvador de la Puente González [:salva]]

Problem here is a little bit tricky, the email seems not being automatically trimmed as it is expected [1] when running production code. When running testing code, all works smooth so I can not reproduce the initial conditions to add a unit test.

The workaround is easy (force trimming) but we need to try to figure out the root cause of the problem. I'm going to file another bug to do this.

[1] http://www.w3.org/html/wg/drafts/html/master/forms.html#e-mail-state-%28type=email%29

Comment 2

[Salvador de la Puente González [:salva]]

Attachment: Force trimming the email value

This is the workaround until bug 920474 is solved.

Comment 3

[Jose Manuel Cantera]

Comment on attachment 809817 [details]
Force trimming the email value

the patch does not solve the problem entirely. It is needed to also check for trimmed values when enabling / disabling the done button. 

var emptyForm = function emptyForm() {
    var textFields = textFieldsCache.get();
    for (var i = textFields.length - 1; i >= 0; i--) {
      if (textFields[i].value && textFields[i].value.trim())
        return false;
    }
    return true;
  };

Comment 4

[Jose Manuel Cantera]

Attachment: 12470.html

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 810477 [details]
12470.html

Working perfectly, tests passing in local.

Thanks for the work Jose

Comment 6

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/8121cf5138f7ff9b0b60e1545f435606f4c6a6d8

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

traige: not a release blocker but please ask for approval to land in v1.2

Comment 8

[Jose Manuel Cantera]

Comment on attachment 810477 [details]
12470.html

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
High

[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):

Low risk patch

[String changes made]:

Comment 9

[Noemí Freire (:noemi)]

Assigning to Francisco for the approval review

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 810477 [details]
12470.html

Non risky change.

a=me

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 8121cf5138f7ff9b0b60e1545f435606f4c6a6d8 to:
v1.2: 8f619bea6cd56e6eade684a3eba4e6bb7a157be8

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 8121cf5138f7ff9b0b60e1545f435606f4c6a6d8 to:
v1.3 already had this commit