Closed
Bug 918937
Opened 12 years ago
Closed 12 years ago
Defect - Regression - Long-tap in url bar, content inputs and links doesn't pop context menu
Categories
(Firefox for Metro Graveyard :: Input, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: sfoster, Assigned: jimm)
References
Details
(Whiteboard: feature=defect c=tbd u=tbd p=1)
Attachments
(1 file, 1 obsolete file)
|
6.58 KB,
patch
|
bbondy
:
review+
|
Details | Diff | Splinter Review |
We seem to have lost the long-tap for right-click/contextmenu across the board. In particular we have no touch-friendly way to paste or cut in the urlbar, or text or other field in content.
|
Assignee | |
Comment 1•12 years ago
|
||
apz or async event work most likely. I'll take a look when I get a chance.
|
||
Updated•12 years ago
|
Blocks: metrov1backlog
Summary: Regression - Long-tap in url bar, content inputs and links doesn't pop context menu → Defect - Regression - Long-tap in url bar, content inputs and links doesn't pop context menu
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → jmathies
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=0
|
|
Assignee | |
Comment 2•12 years ago
|
||
The big issue here was that added HasPointMoved check we added in here. I also cleaned up some other stuff - making sure the recognizer gets cleared and a missing flag in the pointerup handler. With this patch in place our press-hold is working reliably again.
This is built on top of bug 915213 so it'll have to wait for that work to land.
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [preview] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=1
|
|
Assignee | |
Comment 4•12 years ago
|
||
Attachment #809220 -
Attachment is obsolete: true
Attachment #809341 -
Flags: review?(netzen)
|
||
Updated•12 years ago
|
Attachment #809341 -
Flags: review?(netzen) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
|
|
||
Updated•12 years ago
|
|
|
||
Updated•12 years ago
|
Whiteboard: [preview] feature=defect c=tbd u=tbd p=1 → feature=defect c=tbd u=tbd p=1
|
|
||
Comment 7•12 years ago
|
||
Temporarily reopening to add to iteration. Will mark as resolved right after.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Updated•12 years ago
|
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•