918953 - Investigate broken Android WebRTC cleanup code, potential upstream merge errors

Status: NEW

(Core :: WebRTC: Audio/Video, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

http://dxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/audio_device/android/audio_device_jni_android.cc#l63
http://dxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/audio_device/android/audio_device_jni_android.cc#l94

Upstream doesn't have this wtf, so this is a bug of our own or something went wrong during merging.

Video has a similar issue/bug:
http://dxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/video_capture/android/video_capture_android.cc#l71
http://dxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/video_capture/android/video_capture_android.cc#l168

Comment 1

[Gian-Carlo Pascutto [:gcp]]

>Video has a similar issue/bug

This issue seems to be also present in current upstream trunk. Filed upstream issue nr 2410:
https://code.google.com/p/webrtc/issues/detail?id=2410

Comment 2

[Maire Reavy [:mreavy]]

This is an upstream bug