Closed Bug 919033 Opened 12 years ago Closed 12 years ago

Staging server not returning the latest hotfix from the update ping

Categories

(addons.mozilla.org Graveyard :: API, defect)

Product:
addons.mozilla.org Graveyard
Component:
API
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: Felipe, Assigned: jason)

References

Details

Today we pushed a new hotfix version (v20130826.01) to the staging server, which can be seem here https://addons-dev.allizom.org/en-US/firefox/addon/firefox-hotfix/ It's marked as compatible with 10.0 - 24.* Using Firefox 24 on Mac, this is the request generated for the update check: https://addons-dev.allizom.org/update/VersionCheck.php?reqVersion=2&id=firefox-hotfix@mozilla.org&version=&maxAppVersion=%ITEM_MAXAPPVERSION%&status=userEnabled,incompatible&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=24.0&appOS=Darwin&appABI=x86_64-gcc3&locale=en-US&currentAppVersion=24.0&updateType=%UPDATE_TYPE%&compatMode=%COMPATIBILITY_MODE% But that URL doesn't seem to be working: it is redirecting with a 301 to the production server, and it returns a response with no updates available.
Blocks: 874513
any traction here?
Flags: needinfo?(felipc)
Hey Wil, could you take a look at this?
Flags: needinfo?(felipc) → needinfo?(clouserw)
I think Jason would have a better guess
Flags: needinfo?(clouserw) → needinfo?(jthomas)
Assignee: nobody → jthomas
Flags: needinfo?(jthomas)
-dev should now redirect to the correct versioncheck instance at https://versioncheck-dev.allizom.org. We recently did a database refresh on -dev (bug 916188), could you please resubmit the hotfix addon to -dev? Let me know if there are any issues.
Thanks Jason. Jorge, can you resubmit the add-on to -dev for us to test it?
Flags: needinfo?(jorge)
I just uploaded it. Please try again.
Flags: needinfo?(jorge)
I retested with the URL from comment 0, and it's now properly returning the update info for the hotfix. Thanks!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
verified the staging is serving the hotfix correctly. Going to run through testing now. I'll follow up in bug 874513.
Status: RESOLVED → VERIFIED
So, further testing of this with older builds shows this doesn't seem to be completely fixed. I tried 17.0.1 on Mac and that worked correctly. Then I tried 13.0.1 on Win8. It came up with a fingerprint mismatch. I'm trying to get that information from the device now. But the Error console scroll back flooded out that info. And now the latest pings for update are showing the update manifest did not contain an updates property. Going to attempt to reproduce on a VM rather than that infernal Surface Pro so I may be able to catch the Log before it gets flooded away. I will reopen this if I am successful in reproducing.
It's failing against stage with: Timestamp: 9/25/13 10:46:19 AM Error: Expected certificate attribute 'sha1Fingerprint' value incorrect, expected: 'F1:DB:F9:6A:7B:B8:04:FA:48:3C:16:95:C7:2F:17:C6:5B:C2:9F:45', got: 'CA:C4:7D:BF:63:4D:24:E9:DC:93:07:2F:E3:C8:EA:6D:C3:94:6E:89'. Source File: resource://gre/modules/CertUtils.jsm Line: 103 Timestamp: 9/25/13 10:46:19 AM Error: Certificate checks failed. See previous errors for details. Source File: resource://gre/modules/CertUtils.jsm Line: 106 Timestamp: 9/25/13 10:46:19 AM Warning: WARN addons.manager: The hotfix add-on was not signed by the expected certificate and so will not be installed. Source File: resource://gre/modules/AddonManager.jsm Line: 907 I get similar when reverting to default update URL. Except it's looking for the hotfix from 20130322.01: LOG addons.updates: Requesting https://versioncheck-bg.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=firefox-hotfix@mozilla.org&version=&maxAppVersion=%ITEM_MAXAPPVERSION%&status=userEnabled,incompatible&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=13.0.1&appOS=Darwin&appABI=x86_64-gcc3&locale=en-US&currentAppVersion=13.0.1&updateType=%UPDATE_TYPE%&compatMode=%COMPATIBILITY_MODE% LOG addons.repository: Requesting https://services.addons.mozilla.org/en-US/firefox/api/1.5/search/guid:%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D?src=firefox&appOS=Darwin&appVersion=13.0.1&tMain=56&tFirstPaint=1134&tSessionRestored=1266 LOG addons.updates: Found an update entry for firefox-hotfix@mozilla.org version 20130322.01 LOG addons.manager: Downloading hotfix version 20130322.01 LOG addons.xpi: Download started for https://addons.cdn.mozilla.net/storage/public-staging/354399/mozilla_firefox_hotfix-20130322.01-fx.xpi to file /Users/tracy/Library/Caches/TemporaryItems/tmp-dz4.xpi LOG addons.xpi: Download of https://addons.cdn.mozilla.net/storage/public-staging/354399/mozilla_firefox_hotfix-20130322.01-fx.xpi completed. LOG addons.xpi: Verifying XPI signature LOG addons.repository: Requesting https://services.addons.mozilla.org/en-US/firefox/api/1.5/search/guid:firefox-hotfix%40mozilla.org?src=firefox&appOS=Darwin&appVersion=13.0.1 LOG addons.updates: Requesting https://versioncheck-bg.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id={972ce4c6-7e08-4474-a285-3208198ce6fd}&version=13.0.1&maxAppVersion=13.0.1&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=13.0.1&appOS=Darwin&appABI=x86_64-gcc3&locale=en-US&currentAppVersion=13.0.1&updateType=112&compatMode=normal Timestamp: 9/25/13 10:57:48 AM Warning: WARN addons.updates: Update manifest for {972ce4c6-7e08-4474-a285-3208198ce6fd} did not contain an updates property Source File: resource:///modules/AddonUpdateChecker.jsm Line: 313 Timestamp: 9/25/13 10:57:48 AM Error: Expected certificate attribute 'sha1Fingerprint' value incorrect, expected: 'F1:DB:F9:6A:7B:B8:04:FA:48:3C:16:95:C7:2F:17:C6:5B:C2:9F:45', got: 'CA:C4:7D:BF:63:4D:24:E9:DC:93:07:2F:E3:C8:EA:6D:C3:94:6E:89'. Source File: resource://gre/modules/CertUtils.jsm Line: 103 Timestamp: 9/25/13 10:57:48 AM Error: Certificate checks failed. See previous errors for details. Source File: resource://gre/modules/CertUtils.jsm Line: 106 Timestamp: 9/25/13 10:57:48 AM Warning: WARN addons.manager: The hotfix add-on was not signed by the expected certificate and so will not be installed. Source File: resource://gre/modules/AddonManager.jsm Line: 907 LOG addons.xpi: Cancelling download of https://addons.cdn.mozilla.net/storage/public-staging/354399/mozilla_firefox_hotfix-20130322.01-fx.xpi
Firefox's older than 17.0 won't accept this hotfix out-of-box because they were shipped with even older fingerprints. We hotfix-updated them in bug 803596 to accept the new fingerprints. So, failure is expected for anything older than 17.0 unless you've manually applied the old hotfix.
(In reply to Tracy Walker [:tracy] from comment #9) > So, further testing of this with older builds shows this doesn't seem to be > completely fixed. I tried 17.0.1 on Mac and that worked correctly. Then I > tried 13.0.1 on Win8. It came up with a fingerprint mismatch. I'm trying to > get that information from the device now. But the Error console scroll back > flooded out that info. And now the latest pings for update are showing the > update manifest did not contain an updates property. > > Going to attempt to reproduce on a VM rather than that infernal Surface Pro > so I may be able to catch the Log before it gets flooded away. I will > reopen this if I am successful in reproducing. This is expected, FF 10 - FF 16.0 shipped with a different fingerprint, and users will updated to the new fingerprint through a hotfix (i.e., just like what we're doing now). So to test FF 10 - FF 16.0 will need to change the sha1.fingerprint pref to be the same as the current one in FF 17-24. IIRC The 16.0.2 dot release also included the new fingerprint
Ok, I was starting to figure out the older than a year builds problem. Thanks for confirming. manually changed the sha1.fingerprint pref, then let the 13.0.1 build do its thing. It correctly applied the latest hotfix. and updated lastVersion to 20130826.01
my last comment turned out to be tester error, caused by updates having been turned off. we're good to go here.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.