Closed
Bug 919228
Opened 7 years ago
Closed 7 years ago
Top Sites thumbnails make reference to adding bookmarks
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox26 fixed, firefox27 verified, fennec26+)
VERIFIED
FIXED
Firefox 27
People
(Reporter: aaronmt, Assigned: Margaret)
References
Details
Attachments
(3 files)
90.32 KB,
image/png
|
Details | |
3.49 KB,
patch
|
sriram
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
2.37 KB,
patch
|
sriram
:
review+
|
Details | Diff | Splinter Review |
Currently Top Sites thumbnails make references towards adding a bookmark. Should this be replaced with 'Add a site'? Is this a new string? See screenshot -- Nightly (09/21) LG Nexus 4 (Android 4.3)
Reporter | ||
Updated•7 years ago
|
tracking-fennec: --- → ?
Comment 1•7 years ago
|
||
Should read "Add a site" http://cl.ly/image/2E0H0B2u273D
Assignee | ||
Comment 2•7 years ago
|
||
Another string change :(
Assignee: nobody → margaret.leibovic
Attachment #808666 -
Flags: review?(sriram)
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #808669 -
Flags: review?(sriram)
Comment 4•7 years ago
|
||
Comment on attachment 808666 [details] [diff] [review] patch Review of attachment 808666 [details] [diff] [review]: ----------------------------------------------------------------- What happened to the removal? This looks fine.
Attachment #808666 -
Flags: review?(sriram) → review+
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Sriram Ramasubramanian [:sriram] from comment #4) > What happened to the removal? I put it in a separate patch so that if we try to uplift this, we'll only be uplifting one string change, not two.
Comment 6•7 years ago
|
||
Comment on attachment 808669 [details] [diff] [review] (Part 2) Remove unused bookmark_add string Review of attachment 808669 [details] [diff] [review]: ----------------------------------------------------------------- Clever ;)
Attachment #808669 -
Flags: review?(sriram) → review+
Assignee | ||
Comment 7•7 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/c5cb63ccbcbc https://hg.mozilla.org/integration/fx-team/rev/109bda064ff3
Comment 8•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c5cb63ccbcbc https://hg.mozilla.org/mozilla-central/rev/109bda064ff3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Reporter | ||
Updated•7 years ago
|
Updated•7 years ago
|
tracking-fennec: ? → ---
Updated•7 years ago
|
tracking-fennec: --- → 26+
Assignee | ||
Comment 9•7 years ago
|
||
Comment on attachment 808666 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): part of the about:home rewrite (follow-up to bug 917394) User impact if declined: empty thumbnails will have confusing placeholder text Testing completed (on m-c, etc.): landed on m-c Risk to taking this patch (and alternatives if risky): low risk, just a string change String or IDL/UUID changes made by this patch: one string change, I'll cc l10n folks
Attachment #808666 -
Flags: approval-mozilla-aurora?
Comment 10•7 years ago
|
||
Comment on attachment 808666 [details] [diff] [review] patch Needed for the new new about:home. the l10n community is aware of the string change.
Attachment #808666 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•1 month ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•