919365 - [bluedroid]bluedroid stack and tinyxml2 seems not been compiled for nexus-4 (jb4.3)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

[bluedroid]bluedroid stack and tinyxml2 seems not been compiled

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I guess in the original packages/apps/Bluetooth/Android.mk, there is a flag called "LOCAL_REQUIRED_MODULES" which set build dependency. Since b2g project does not use java app. So the package won't be built.

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

https://github.com/shuangMoz/device-mako/commit/3121759bc046ff4064d191dd6a60da393eba8b15

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: 0001-Add-bluedroid-library-bluetooth.default-to-mako.patch

By default, bluedroid library was not been compiled and installed into device mako b2g. If GeckoBluetooth required to support bluedroid, we need to install library bluetooth.default. Since it is possible that we need to support different combinations such as "Gecko + ICS + Bluez", "Gecko + JB + BlueZ", "Gecko + JB + Bluedroid". I preferred to config this part in device.mk.

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 809724 [details] [diff] [review]
0001-Add-bluedroid-library-bluetooth.default-to-mako.patch

Looks fine. Just move it to the gecko section near the bottom of the file and add a space after # like all other comments in the file.

Comment 5

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Final-Add-bluedroid-library-bluetooth.default-to-mako.patch

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Final-Add-bluedroid-library-bluetooth.default-to-mako.patch

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Pull request:
https://github.com/mozilla-b2g/device-mako/pull/6
https://github.com/mozilla-b2g/device-mako/pull/5

Comment 8

[Michael Wu [:mwu]]

Merged pull request 5.

I'm not planning to make any updates to the mako 4.2 branch at the moment, as we have zero support on the build or infra side for this.