919447 - Add tests for MMI additions to "callOrPick"

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

koi+ as bug 908117 is koi+

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12625

Pointer to Github pull-request

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

We all love tests, but AFAIK we don't block a release because of missing tests (specially for a modification of a function which never had tests before). Please, honor the meaning of a blocking flag by using it for blocking issues.

Waiting for Travis before asking for review.

Comment 4

[Anthony Ricaud (:rik)]

You're right, I should have expressed the need for tests before the code landed. Since it is tests only, we can land with approval-gaia-v1.2 to ensure this doesn't regress.

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Thanks Anthony.

The tests are green locally, but are failing in Travis. I can't reproduce the failure locally because of bug 923708.

Comment 6

[Julien Wajsberg [:julienw]]

When it's tests only, you can run without asking approval, with a=tests.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

MMI code has been refactor.