919683 - Remote debugger in the webapp runtime broken by bug 880930

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect)

Description

[Marco Castelluccio [:marco]]

Attachment: fix_debugger_webapprt

Regression from bug 880930.
We should really get the webapprt-test-chrome tests to run on tbpl!

(If you want to run them locally, you just have to run |mach webapprt-test-chrome|)

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 808742 [details] [diff] [review]
fix_debugger_webapprt

Review of attachment 808742 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Marco Castelluccio [:marco] from comment #0)
> Regression from bug 880930.
> We should really get the webapprt-test-chrome tests to run on tbpl!

That would be great!

> (If you want to run them locally, you just have to run |mach
> webapprt-test-chrome|)

I tried that, but I get:

Error running mach:

    ['webapprt-test-chrome']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

NameError: global name 'mozinfo' is not defined

  File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line 513, in run_mochitest_webapprt_chrome
    return self.run_mochitest(test_file, 'webapprt-chrome', **kwargs)
  File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line 528, in run_mochitest
    **kwargs)
  File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line 269, in run_desktop_test
    options.app = self.get_webapp_runtime_path()
  File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line 81, in get_webapp_runtime_path
    appname = 'webapprt-stub' + mozinfo.info.get('bin_suffix', '')


Do I have to do anything else first, like have a special .mozconfig?

Comment 2

[Marco Castelluccio [:marco]]

(In reply to Panos Astithas [:past] from comment #1)
> > (If you want to run them locally, you just have to run |mach
> > webapprt-test-chrome|)
> 
> I tried that, but I get:
> 
> Error running mach:
> 
>     ['webapprt-test-chrome']
> 
> The error occurred in the implementation of the invoked mach command.
> 
> This should never occur and is likely a bug in the implementation of that
> command. Consider filing a bug for this issue.
> 
> If filing a bug, please include the full output of mach, including this error
> message.
> 
> The details of the failure are as follows:
> 
> NameError: global name 'mozinfo' is not defined
> 
>   File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line
> 513, in run_mochitest_webapprt_chrome
>     return self.run_mochitest(test_file, 'webapprt-chrome', **kwargs)
>   File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line
> 528, in run_mochitest
>     **kwargs)
>   File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line
> 269, in run_desktop_test
>     options.app = self.get_webapp_runtime_path()
>   File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line
> 81, in get_webapp_runtime_path
>     appname = 'webapprt-stub' + mozinfo.info.get('bin_suffix', '')
> 
> 
> Do I have to do anything else first, like have a special .mozconfig?

Quite ironic, yesterday even the mach command has regressed! (because of bug 746243)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/02e62e85c4ad

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/02e62e85c4ad