Closed
Bug 919683
Opened 11 years ago
Closed 11 years ago
Remote debugger in the webapp runtime broken by bug 880930
Categories
(Firefox Graveyard :: Webapp Runtime, defect)
Firefox Graveyard
Webapp Runtime
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: marco, Unassigned)
References
Details
Attachments
(1 file)
1.10 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
Regression from bug 880930. We should really get the webapprt-test-chrome tests to run on tbpl! (If you want to run them locally, you just have to run |mach webapprt-test-chrome|)
Attachment #808742 -
Flags: review?(past)
Comment 1•11 years ago
|
||
Comment on attachment 808742 [details] [diff] [review] fix_debugger_webapprt Review of attachment 808742 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Marco Castelluccio [:marco] from comment #0) > Regression from bug 880930. > We should really get the webapprt-test-chrome tests to run on tbpl! That would be great! > (If you want to run them locally, you just have to run |mach > webapprt-test-chrome|) I tried that, but I get: Error running mach: ['webapprt-test-chrome'] The error occurred in the implementation of the invoked mach command. This should never occur and is likely a bug in the implementation of that command. Consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: NameError: global name 'mozinfo' is not defined File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line 513, in run_mochitest_webapprt_chrome return self.run_mochitest(test_file, 'webapprt-chrome', **kwargs) File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line 528, in run_mochitest **kwargs) File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line 269, in run_desktop_test options.app = self.get_webapp_runtime_path() File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line 81, in get_webapp_runtime_path appname = 'webapprt-stub' + mozinfo.info.get('bin_suffix', '') Do I have to do anything else first, like have a special .mozconfig?
Attachment #808742 -
Flags: review?(past) → review+
Reporter | ||
Comment 2•11 years ago
|
||
(In reply to Panos Astithas [:past] from comment #1) > > (If you want to run them locally, you just have to run |mach > > webapprt-test-chrome|) > > I tried that, but I get: > > Error running mach: > > ['webapprt-test-chrome'] > > The error occurred in the implementation of the invoked mach command. > > This should never occur and is likely a bug in the implementation of that > command. Consider filing a bug for this issue. > > If filing a bug, please include the full output of mach, including this error > message. > > The details of the failure are as follows: > > NameError: global name 'mozinfo' is not defined > > File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line > 513, in run_mochitest_webapprt_chrome > return self.run_mochitest(test_file, 'webapprt-chrome', **kwargs) > File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line > 528, in run_mochitest > **kwargs) > File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line > 269, in run_desktop_test > options.app = self.get_webapp_runtime_path() > File "/Users/past/src/fx-team/testing/mochitest/mach_commands.py", line > 81, in get_webapp_runtime_path > appname = 'webapprt-stub' + mozinfo.info.get('bin_suffix', '') > > > Do I have to do anything else first, like have a special .mozconfig? Quite ironic, yesterday even the mach command has regressed! (because of bug 746243)
Keywords: checkin-needed
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/02e62e85c4ad
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/02e62e85c4ad
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Assignee | ||
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•