92003 - SSL/SMTP fails if not logged into cert db.

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P1)

Description

[ji]

Build: Mac 07/23 branch build.

With SSL SMTP, I'm unable to send out mails. After clicking on Send button, the
sending status window pops up and so does certificate selection window. But the 
window focus stays on sending status window, so it makes me impossible to select 
certificate and send out mails.

Steps to reproduce:
1. Get an AOL certificate at https://certificates.netscape.com/ and install it 
on your client.
2. Go to Edit | Prefrences | Privacy and Security | Certificates
   Check on Ask Every Time
3. Set you SMTP account use SSL
4. Compose a mail and click on Send
   The sending status window comes up, then certificate window comes up too. But 
the window focus stays on status window, and you can't do anything with that.

Comment 1

[ji]

Windows and linux build don't have window focus problem, but I'm unable to send 
out mails with SSL either on these two platforms. I got an error message saying 
that sending has failed.

Comment 2

[ji]

After I check on Use name and password, I can send out mails on windows and 
linux, but Mac build still have this window focus problem.

Comment 3

[Stephane Saux]

This won't make it into the branch.
t->2.1
P1
->javi

Comment 4

[John Unruh]

Reproducible. Adding crash and relnote keywords. The workaround is to leave the 
pref setting under Certificates to "Select Automatically".

Comment 5

[ji]

Checking on "Select Automatically" actually is not working. I got an error 
message saying that "Sending of message failed"

Comment 6

[marina]

there was a bug filed for SSL and the only workaround proposed was to set SSL
prefs to "Never"

Comment 7

[Javier Delgadillo]

Do we know when this last worked?

Comment 8

[ji]

Tried 07/24 build with a new profile. "Select Automatically" works. I can send 
out mails with SSL with that preference setting. 
Marina, in the case that browser doesn't have any certificate installed, sending 
will fail if you don't use "Never" option. That's why "Nerver" is the default 
choice now when setting up SMTP. But that problem doesn't exist if browser has 
certificate installed.

Comment 9

[marina]

so with no cert we chose "Never" ( nothing else works), with the cert every
option is available?

Comment 10

[ji]

With 07/24 branch build, with or w/o cert, every option is available. It seems 
that problem that you can only choose "Never" (in the case no cert is installed) 
has been fixed.
Not sure about trunk. 

Comment 11

[Stephane Saux]

adding nsenterprise to all P1, P2 PSM bugs with target milestone of 2.1

Comment 12

[John Unruh]

Mass assigning QA to ckritzer.

Comment 13

[Javier Delgadillo]

The parenting problem seems to have fixed itself, but now I get prompted for a
certificate twice, then it actually sends the message.  (Not sure if SSL
eventually succeeds or if SMTP code falls back to non-SSL connection.)

Comment 14

[Javier Delgadillo]

I'm not sure why there are 2 connections being created in this case.

mscott:  Is it normal for the SMTP to make 2 connections?  It seems that it
makes one connection to the SMTP server, then another one to the IMAP server to
copy the message to my Send folder.

I'm about to post the patch I've got so far, if mscott says the behavior is
normal, then the attached patch will be the proposed fix.

Comment 15

[Javier Delgadillo]

Attachment: Patch that makes it so that we get prompted for password.

Comment 16

[Scott MacGregor]

hey javi, it is true that we will create 2 server connections if your sent
folder is an imap folder. So one connection for the smtp protocol and one
connection for imap to put the message in your sent folder. 

If you are seeing 2 STMP connections then that would be a problem. Is that the
case? or is the 2nd connection the imap server.

Comment 17

[Javier Delgadillo]

I'm assuming the second connection is to the IMAP server since it says"Copying
message to Sent folder" as I get prompted the second time.  It just "feels" like
there are 2 SMTP connections because the cert selection dialog comes up again
almost instantaneously.

The attached patch is still require just in case the user is not logged into
his/her cert db at the time the message is sent.

Comment 18

[David P. Drinan]

r=ddrinan.

Comment 19

[Javier Delgadillo]

Updating summary.

Comment 20

[Scott MacGregor]

sr=mscott

Comment 21

[Javier Delgadillo]

Patch checked in.

Comment 22

[ckritzer (gone)]

This is FIXED on:
- MacOS91 2001-08-21-04-trunk (commercial)
- LinRH62 2001-08-21-06-trunk (commercial)
- Win98SE 2001-08-21-11-trunk (commercial)

But crashes on:
- MacOS_X 2001-08-21-05-trunk (commercial)

Comment 23

[ckritzer (gone)]

Removing dependancy, marking VERIFIED FIXED, adding note to self to re-verify on
MacOS_X when 96419 is fixed.

Marking VERIFIED FIXED on:
- MacOS91 2001-08-21-04-trunk (commercial)
- LinRH62 2001-08-21-06-trunk (commercial)
- Win98SE 2001-08-21-11-trunk (commercial)

VERIFICATION PENDING on:
- MacOS_X 2001-08-21-05-trunk (commercial)