920111 - From header having only spaces as display name (" " <[e-mail]>) is invisible on message header, should show email address instead

Status: RESOLVED WORKSFORME

(Thunderbird :: Untriaged, enhancement)

Description

[peekaa]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20130910160258

Steps to reproduce:

I received a mail from 

Received: from unknown ([78.156.48.158])
	by email.seznam.cz (szn-ebox-4.4.83.2) with HTTP;
	Tue, 24 Sep 2013 18:33:35 +0200 (CEST)
From: " " <[e-mail]>
To: "YYYYYYYYY" <[e-mail]>
Subject: Re: Ahoj
Date: Tue, 24 Sep 2013 18:33:35 +0200 (CEST)
....




Actual results:

In main window in TB in column From there is nothing. 


Expected results:

Maybe there is "space" but seems like nothing. Thats pretty ungood. In this cases there should rather be the senders email adress.

Comment 1

[Thomas D. (:thomas8)]

If this happens as described, yes, it would be better to show the email address.
However, looks like an edge case to me, why would somebody specify an empty display name?

Comment 2

[peekaa]

Really dont know, its rare case, but it is.

Comment 3

[WADA:World Anti-bad-Duping Agency]

display-name in mail address is processed around here(Author==From: case)
http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMsgDBView.cpp#407
As seen in code, check is done for null/undefined etc.
> 407   if (aSenderString.IsEmpty())
> 411     if (!name.IsEmpty())
IIUC, space doesn't return IsEmpty()==true in CPP code, although "if(string-of-space) of JavaScript" returns 0(==false).
These should be changed to code like "if ( aSenderString.IsEmpty() || aSenderString.IsSpace() )", "if ( !name.IsEmpty()  && !name.IsSpace() )", or IsEmptyOrSpace() should be implemented, or "logic to remove all preceeding/traing spaces upon name extraction from header" should be implemented, if this bug's case will be supported by Tb.

Another way :
Implement mode to show both display-name and angle-address, instead of forcing mode of "display-name only if display-name exists" always, or implement mode of "show mail-address always, instead of showing display-name only".
.

Comment 4

[Alessandro Castellani [:aleca]]

I can't reproduce this on daily.
If I load a test email with a From: " " <[e-mail]> I see [e-mail] in the From column.
Do you still see this problem?

Comment 5

[Alessandro Castellani [:aleca]]

Closing this, can be reopened if the problem is still present.