Closed
Bug 920201
Opened 11 years ago
Closed 11 years ago
Australis: Move tests into manifest, nuke last Makefile.in (yay!)
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Whiteboard: [Australis:M9][Australis:P5])
Attachments
(1 file)
|
2.91 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
As per https://groups.google.com/forum/?fromgroups#!topic/mozilla.dev.platform/qXM5qMpJ1bQ , we can now use a test manifest and moz.build to define browser mochitests, which means we can get rid of our last makefile. Hurray!
|
Assignee | |
Comment 1•11 years ago
|
||
Can't do this until bug 901990 merges to m-c and then UX.
Depends on: 901990
|
|
Assignee | |
Comment 2•11 years ago
|
||
This should do the trick. Tested locally on my windows box, it seems to work.
Attachment #809848 -
Flags: review?(gps)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → gijskruitbosch+bugs
|
||
Comment 3•11 years ago
|
||
Comment on attachment 809848 [details] [diff] [review]
move tests into manifest,
Review of attachment 809848 [details] [diff] [review]:
-----------------------------------------------------------------
The moz.build entry for test manifests can be in any moz.build file!
For performance reasons, we want to reduce the number of moz.build files in the tree. Before check in, please add the BROWSER_CHROME_MANIFESTS += ['browser.ini'] line to a moz.build in a parent directory. Say browser/components/customizableui/moz.build.
Attachment #809848 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: NEW → ASSIGNED
Whiteboard: [Australis:M9][Australis:P5] → [Australis:M9][Australis:P5][fixed-in-ux]
|
|
Assignee | |
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M9][Australis:P5][fixed-in-ux] → [Australis:M9][Australis:P5]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•