920317 - Bottom of top sites list is cut off when home banner is enabled

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[:Margaret Leibovic]

To reproduce, you can install this add-on:
https://github.com/leibovic/promo-banner/releases/tag/0.1

Then start scrolling the top sites page on about:home.

Comment 1

[:Margaret Leibovic]

Attachment: screenshot

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Done.

Comment 3

[:Margaret Leibovic]

Comment on attachment 810819 [details] [diff] [review]
Patch

Thanks for the fix!

Comment 4

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/fx-team/rev/5996743f47bf

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5996743f47bf

Comment 6

[Lucas Rocha (:lucasr)]

Sriram, request uplift to Aurora?

Comment 7

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 810819 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new-new-about-home changes.
User impact if declined: Bottom row is cut off in top-sites.
Testing completed (on m-c, etc.): Landed 15 days back.
Risk to taking this patch (and alternatives if risky): None. 
String or IDL/UUID changes made by this patch: None.

Comment 8

[Sriram Ramasubramanian [:sriram]]

This depends on Bug 919704.

Comment 9

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9c524d4d834a